Skip git tests on Windows #5891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From 5m 47s to 4m 47s for the |
|
Happy to hear thoughts on this, I don't know how nuanced the git behavior is on Windows specifically. We could adjust the features on |
|
I think I'd leave this as-is for now given those numbers. Though it's possible we're not using this feature everywhere we should. |
|
With #5910 we go from 6m 12s (7m 42s total) to 4m 41s (5m 57s total) for a 25% (22% total) improvement. |
|
(Previously it was about 17%) |
charliermarsh
approved these changes
Aug 8, 2024
|
I'm cool with it, I think. |
|
If we have a regression it's easy to revert! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might be pushing it on test coverage, but these are some of our slowest tests we might get a significant speedup here.
Part of #5713