Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect subdirectories when locating Git workspaces #5944

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Respect subdirectories when locating Git workspaces #5944

merged 1 commit into from
Aug 9, 2024

Conversation

charliermarsh
Copy link
Member

Summary

We were discovering the workspace from the Git repository root, so attempting to build any subdirectories would fail.

Closes #5942.

Test Plan

cargo run pip install \
	git+https://github.com/flyteorg/flytekit.git@master#subdirectory=plugins/flytekit-flyteinteractive

@charliermarsh
Copy link
Member Author

It's so hard to construct a test for this.

@charliermarsh
Copy link
Member Author

You need:

  • A Git repository whose name also exists as a PyPI package.
  • With a pyproject.toml at the root.
  • With a subdirectory containing another package.
  • And that sub-package needs to declare a dependency on the package root.

@charliermarsh charliermarsh added the bug Something isn't working label Aug 9, 2024
@charliermarsh charliermarsh merged commit ba7c09e into main Aug 9, 2024
57 checks passed
@charliermarsh charliermarsh deleted the charlie/sub branch August 9, 2024 00:13
@charliermarsh
Copy link
Member Author

I tried but gave up.

zanieb pushed a commit that referenced this pull request Aug 9, 2024
@charliermarsh @zanieb
Respect subdirectories when locating Git workspaces (#5944)
66b6d7a 
We were discovering the workspace from the Git repository root, so
attempting to build any subdirectories would fail.

Closes #5942.

```
cargo run pip install \
	git+https://github.com/flyteorg/flytekit.git@master#subdirectory=plugins/flytekit-flyteinteractive
```
@BrewTestBot BrewTestBot mentioned this pull request Aug 10, 2024
Merged
@thomasjpfan thomasjpfan mentioned this pull request Aug 10, 2024
Merged
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Aug 10, 2024
@tmeijn
build(deps): update astral-sh/uv to v0.2.35
8aff83d 
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.2.33` -> `0.2.35` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>astral-sh/uv (astral-sh/uv)</summary>

### [`v0.2.35`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0235)

[Compare Source](astral-sh/uv@0.2.34...0.2.35)

##### CLI

-   Deprecate `--system` and `--no-system` in `uv venv` ([#&#8203;5925](astral-sh/uv#5925))
-   Make `--upgrade` imply `--refresh` ([#&#8203;5943](astral-sh/uv#5943))
-   Warn when there are missing bounds on transitive dependencies with `--resolution-strategy lowest` ([#&#8203;5953](astral-sh/uv#5953))

##### Configuration

-   Add support for `no-build-isolation-package` ([#&#8203;5894](astral-sh/uv#5894))

##### Performance

-   Enable LTO optimizations in release builds to reduce binary size ([#&#8203;5904](astral-sh/uv#5904))
-   Prefetch metadata in `--no-deps` mode ([#&#8203;5918](astral-sh/uv#5918))

##### Bug fixes

-   Display portable paths in POSIX virtual environment activation commands ([#&#8203;5956](astral-sh/uv#5956))
-   Respect subdirectories when locating Git workspaces ([#&#8203;5944](astral-sh/uv#5944))

##### Documentation

-   Improve the `uv venv` CLI documentation ([#&#8203;5963](astral-sh/uv#5963))

### [`v0.2.34`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0234)

[Compare Source](astral-sh/uv@0.2.33...0.2.34)

##### Enhancements

-   Always strip in release mode ([#&#8203;5745](astral-sh/uv#5745))
-   Assume `git+` prefix when URLs end in `.git` ([#&#8203;5868](astral-sh/uv#5868))
-   Support build constraints ([#&#8203;5639](astral-sh/uv#5639))

##### CLI

-   Create help sections for build, install, resolve, and index ([#&#8203;5693](astral-sh/uv#5693))
-   Improve CLI documentation for global options ([#&#8203;5834](astral-sh/uv#5834))
-   Improve `--python` CLI documentation ([#&#8203;5869](astral-sh/uv#5869))
-   Improve display order of top-level commands ([#&#8203;5830](astral-sh/uv#5830))

##### Bug fixes

-   Allow downloading wheels for metadata with `--no-binary` ([#&#8203;5707](astral-sh/uv#5707))
-   Reject `pyproject.toml` in `--config-file` ([#&#8203;5842](astral-sh/uv#5842))
-   Remove double-proxy nodes in error reporting ([#&#8203;5738](astral-sh/uv#5738))
-   Respect pre-release preferences from input files ([#&#8203;5736](astral-sh/uv#5736))
-   Support overlapping local and non-local requirements in forks ([#&#8203;5812](astral-sh/uv#5812))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
@charliermarsh charliermarsh mentioned this pull request Aug 14, 2024
Closed
@zanieb zanieb mentioned this pull request Aug 14, 2024
Merged
zanieb added a commit that referenced this pull request Aug 14, 2024
@zanieb
Fix loading of cached metadata for git distributions with subdirector…
dc67023 
…ies (#6094)

Applies the same fix as #5944 to
cache loads

Closes #6093
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to install subdirectory plugin using uv pip install
1 participant
@charliermarsh