Filter mixed sources from --find-links
entries in lockfile
#6025
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our current handling of
--find-links
merges the entries in each index. As a result, we can end up withAnnotatedDist
entries that reference distributions across indexes.I'd like to change
--find-links
such that each--find-links
entry is just treated as its own index (so, e.g., ifrequests
exists in the first--find-links
entry, we don't even check the registry by default), which would also fix this problem automatically. But that's a behavior change... So for now, in the lockfile, we filter distributions that don't match the source index URL.There are two cases to consider:
--find-links
registry, the source distribution must have come from the--find-links
entry, so it's fine to discard any wheels from the "wrong" registry without breaking any compatibility guarantees.--find-links
registry. We might lose some platform coverage by discarding the other wheels, but it shouldn't break any of the "guarantees", since we have at least one wheel that fits in the version range.Closes #6015.