Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move anchors validation to only the public mkdocs config #6099

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Move anchors validation to only the public mkdocs config #6099

merged 1 commit into from
Aug 15, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Aug 15, 2024 •
edited
Loading

@zanieb zanieb added documentation Improvements or additions to documentation internal A refactor or improvement that is not user-facing labels Aug 15, 2024
@zanieb zanieb marked this pull request as ready for review August 15, 2024 00:37
@zanieb zanieb merged commit f28ce54 into main Aug 15, 2024
46 checks passed
@zanieb zanieb deleted the zb/fix-main-anchors branch August 15, 2024 00:37
@zanieb
Copy link
Member Author

zanieb commented Aug 15, 2024

We can do better here, but I want to fix main and move on with my evening :)

Thanks again @mkniewallner

@zanieb zanieb mentioned this pull request Aug 27, 2024
Merged
zanieb added a commit that referenced this pull request Aug 27, 2024
@zanieb
Always run both public and private documentation checks (#6707)
6d38d42 
Avoiding failures like #6705

Context in #6099

## Test plan

Even though I opened the pull request, the public build was still
tested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkniewallner mkniewallner mkniewallner approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation internal A refactor or improvement that is not user-facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zanieb @mkniewallner