Add env var to --link-mode=copy warning
#6103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
that looks good, Charlie - thank you for this improvement. |
charliermarsh
commented
Aug 15, 2024
| @@ -563,7 +563,7 @@ fn hardlink_wheel_files( | |||
| } | |||
| Attempt::UseCopyFallback => { | |||
| synchronized_copy(path, &out_path, locks)?; | |||
| warn_user_once!("Failed to hardlink files; falling back to full copy. This may lead to degraded performance. If this is intentional, use `--link-mode=copy` to suppress this warning.\n\nhint: If the cache and target directories are on different filesystems, hardlinking may not be supported."); | |||
| warn_user_once!("Failed to hardlink files; falling back to full copy. This may lead to degraded performance.\n If this is intentional, set `UV_LINK_MODE=copy` or use `--link-mode=copy` to suppress this warning.\n\nhint: If the cache and target directories are on different filesystems, hardlinking may not be supported."); | |||
There was a problem hiding this comment.
Oops, need to update these to match the above format.
charliermarsh
force-pushed
the
charlie/link-mode-env
branch
from
c2ff572
to
b0a13ab
Compare
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Aug 19, 2024
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.2.36` -> `0.2.37` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.2.37`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0237) [Compare Source](astral-sh/uv@0.2.36...0.2.37) ##### Performance - Avoid cloning requirement for unchanged markers ([#​6116](astral-sh/uv#6116)) ##### Bug fixes - Fix loading of cached metadata for Git distributions with subdirectories ([#​6094](astral-sh/uv#6094)) ##### Error messages - Add env var to `--link-mode=copy` warning ([#​6103](astral-sh/uv#6103)) - Avoid displaying "failed to download" on build failures for local source distributions ([#​6075](astral-sh/uv#6075)) - Improve display of available package ranges ([#​6118](astral-sh/uv#6118)) - Use "your requirements" consistently in resolver error messages ([#​6113](astral-sh/uv#6113)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #6101.
Test Plan