Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sets rather than vectors for lockfile requirements #6107

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

charliermarsh
Copy link
Member

Summary

Ensures that --locked is robust to reordering and duplicates.

@charliermarsh charliermarsh added the internal A refactor or improvement that is not user-facing label Aug 15, 2024
@charliermarsh charliermarsh marked this pull request as ready for review August 15, 2024 12:28
@charliermarsh charliermarsh added enhancement New feature or request preview Experimental behavior lock Related to universal resolution and locking and removed internal A refactor or improvement that is not user-facing labels Aug 15, 2024
Copy link
Member

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@charliermarsh charliermarsh force-pushed the charlie/ord branch 2 times, most recently from f68e27c to 3b033cb Compare August 15, 2024 12:45
@charliermarsh charliermarsh enabled auto-merge (squash) August 15, 2024 12:45
@charliermarsh charliermarsh enabled auto-merge (squash) August 15, 2024 12:57
@charliermarsh charliermarsh merged commit 2917957 into main Aug 15, 2024
56 checks passed
@charliermarsh charliermarsh deleted the charlie/ord branch August 15, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lock Related to universal resolution and locking preview Experimental behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants