Fix uv run python when the executable has a different name
#6362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
commented
Aug 21, 2024
zanieb
force-pushed
the
zb/run-python-missing
branch
from
51f700e
to
da48f30
Compare
| @@ -742,6 +741,20 @@ impl RunCommand { | |||
| process | |||
| } | |||
| Self::External(executable, args) => { | |||
| // If the executable is `python` and it's not on the path, rename it to the | |||
| // path reported by the interpreter. | |||
There was a problem hiding this comment.
Could this not resolve to some Python that doesn't match the intended interpreter? Like you run uv run -p 3.9, but we then pick up Python 3.12 that's on your path?
There was a problem hiding this comment.
Yeah but what if you have a python executable in the interpreter bin that does some special behavior? Should we unconditionally switch to the sys executable? Should we just look in the interpreter bin instead of the whole PATH here?
There was a problem hiding this comment.
Seems problematic both ways. I'm okay with unconditional replacement, I guess?
There was a problem hiding this comment.
Here's that approach #6363
zanieb
force-pushed
the
zb/run-python-pin
branch
from
ae06205
to
2a8f458
Compare
zanieb
force-pushed
the
zb/run-python-missing
branch
from
da48f30
to
6b2dd80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.