-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sort dependencies in pyproject.toml
#6388
Merged
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
10426e1
fix tests
ChannyClaus 9c131a5
clippy
ChannyClaus 279f653
place the version constraint on the correct index
ChannyClaus 01ecc17
fix the test (should be failing)
ChannyClaus 7e3291e
index fix + need to fix more tests
ChannyClaus c80112a
fix add_update_marker
ChannyClaus b98054f
compare both name and extras
ChannyClaus 1217cc6
move 'sorted' into the conditional since it's only used inside
ChannyClaus acaf703
remove unnecessary assignment
ChannyClaus f454d23
omit syncing in the tests
ChannyClaus 2659dc7
add itertools to uv-workspace
ChannyClaus 9934544
need to fix reformatting
ChannyClaus fe7fbfe
handle the indentation edge case
ChannyClaus e1e55f9
add check for str
ChannyClaus 7f33e71
clippy
ChannyClaus 4e3031d
fix typo
ChannyClaus db2af85
Don't lock on sortedness tests
konstin c27bf33
Simplify sorting logic
konstin ae86833
merge main
konstin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix the test (should be failing)
- Loading branch information
commit 01ecc17c8a8362d590b991c675df4ae5da66f268
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should only pass when all values are strings. If they aren't the table is invalid; We could error, but for simplicity here it makes more sense to treat invalid files as unsorted, add our requirement to the end of the list and let it fail later when we try to use the pyproject.toml