Add explicit error message for URLs without package names #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added a commit
that referenced
this pull request
Mar 11, 2024
…ts (#2369) ## Summary This is analogous to #669, but for cases in which the package name is a filesystem path. In such cases, we'll fail when parsing the _package name_, since it doesn't start with a valid character, as opposed to failing when we go to parse the remaining version specifier. Inspired by #2356.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pipsupports installing packages without names (e.g.,git+https://github.com/pallets/flask.git), but it doesn't adhere to the PEP grammar, and we don't yet support it (and may never) (#313).This PR adds a dedicated error path for such cases, to ensure that we can give meaningful feedback to the user:
Closes #650.