installation.md: update shell syntax for setting env vars #7138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find this more readable; it also no longer requires bash (thought just replacing
bash
withsh
would achieve that much).Strictly speaking,
env
is not necessary on most shells, but I find it makes things clearer.Test Plan
Ran the command locally, did not try compiling the docs.
Aside, loosely related (and hopefully helpful) suggestions:
I'm hoping you will also explain in the docs how to install to
~/.local/bin
, with the same goal as #6839. Using environment variables for that is fine.Another minor FR I'd have is to mention these environment variables in the help message of the installer script, especially if you want to encourage people to use them.
Thank you for working on the installation script! It helps me feel more comfortable about eventually asking that people install
uv
to compile docs on my project, hopefully helping people who don't have a Python environment already installed.