Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): adjust xwin timeout and revert xwin jobs being disabled #8187

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

samypr100
Copy link
Collaborator

@samypr100 samypr100 commented Oct 14, 2024

Summary

Reverts #8181 and #8182.

The fix is in b849f0f, which extends the run timeout to allow xwin to download the Windows SDK files, which can take 10+ minutes.

Closes rust-cross/cargo-xwin#127

Test Plan

Existing CI should pass.

Notes

xwin jobs will take a long time the first time due to cache re-warming.

@samypr100 samypr100 marked this pull request as ready for review October 14, 2024 20:01
@zanieb
Copy link
Member

zanieb commented Oct 14, 2024

I wonder if we should even be using xwin for the main Clippy job since it's ~as fast with the native setup?

@zanieb
Copy link
Member

zanieb commented Oct 14, 2024

Thanks a bunch of identifying this issue!

@samypr100
Copy link
Collaborator Author

I wonder if we should even be using xwin for the main Clippy job since it's ~as fast with the native setup?

I think the gain is more-so on the windows-latest-xlarge vs ubuntu-latest / costs and the speed that the job takes to start (total job speeds).

The runs perform the same, I mentioned it here #3600 (comment)

iirc, I did compare windows-latest vs ubuntu-latest (not xlarge) and it was about 30s slower. xlarge was about the same for clippy.

Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zanieb zanieb added the internal A refactor or improvement that is not user-facing label Oct 14, 2024
@zanieb zanieb merged commit db0f0ae into astral-sh:main Oct 14, 2024
61 checks passed
@samypr100 samypr100 deleted the xwin-revival branch October 14, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show messages on non-interactive download
2 participants