Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mold for linking in CI tests #887

Merged
merged 9 commits into from
Jan 11, 2024
Merged

Use mold for linking in CI tests #887

merged 9 commits into from
Jan 11, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Jan 11, 2024

Derived from #875

This gets us a significant speedup.

I would not read the commits individually. I can squash them but they were used for testing various scenarios.

Test compile times

Ranges are the lowest and highest I've seen. Huge variability in GitHub Actions runners.

Before:
7m 21s - 8m 22s (cold cache)
110s - 120s (warm cache)

After:
6m 15s - 7m 05s (cold cache)
57s - 70s (warm cache)

Improvement:
4% - 25% (cold cache)
36% - 52% (warm cache)

@zanieb zanieb marked this pull request as ready for review January 11, 2024 18:20
@zanieb
Copy link
Member Author

zanieb commented Jan 11, 2024

I think this is worth merging separately from #875. It'll be easier to tell if that's worthwhile once this lands.

@zanieb zanieb merged commit 90edfa8 into main Jan 11, 2024
3 checks passed
@zanieb zanieb deleted the zb/mold branch January 11, 2024 18:28
@zanieb zanieb mentioned this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants