Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a larger runner for tests #889

Merged
merged 9 commits into from
Jan 11, 2024
Merged

Use a larger runner for tests #889

Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ab8395f
Use a 4-core larger runner for tests
zanieb Jan 11, 2024
b11f1e9
Use `nextest` test runner
zanieb Jan 10, 2024
06c0ab1
Use 8-core runner
zanieb Jan 11, 2024
b673cae
Restore insta test runner
zanieb Jan 11, 2024
d2a5299
Restore nextest runner
zanieb Jan 11, 2024
9299917
Increase thread count for nextest to 12
zanieb Jan 11, 2024
2702ad6
Increase thread count to 16
zanieb Jan 11, 2024
d881e14
Return to 12 threads
zanieb Jan 11, 2024
aef848a
Update name of larger runner
zanieb Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,11 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
runs-on: ${{ matrix.os }}
runs-on:
# TODO(zanieb): The runner labels should be changed to include the OS and
# templated here or moved to the matrix depending on how we
# want things to display
labels: astral-8-core
Copy link
Member Author

@zanieb zanieb Jan 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merge, an organization admin (@charliermarsh) needs to change the name of this runner to ubuntu-latest-large-8 or similar.

The macOS runners are named "macos-latest-large" and "macos-latest-xlarge". We could consider just using "ubuntu-latest-large" for consistency in our workflow and change the number of cores in the admin panel as needed. A consistent name would make it really easy for us to have just the OS in the matrix.

name: "cargo test | ${{ matrix.os }}"
steps:
- uses: actions/checkout@v4
Expand All @@ -67,9 +71,12 @@ jobs:
uses: taiki-e/install-action@v2
with:
tool: cargo-insta
- name: "Install cargo nextest"
uses: taiki-e/install-action@v2
with:
tool: cargo-nextest
- uses: Swatinem/rust-cache@v2
with:
save-if: ${{ github.ref == 'refs/heads/main' }}
- name: "Tests (Ubuntu)"
if: ${{ matrix.os == 'ubuntu-latest' }}
run: cargo insta test --all --all-features --unreferenced reject
- name: "Tests"
run: cargo nextest run --all --all-features --status-level skip --failure-output immediate-final --no-fail-fast -j 12