-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs(GitLab): add entrypoint for distroless image #9093
Conversation
Hm I thought we removed the custom entrypoint in #7054 |
This is the image I used:
Could this be why? My project is still using that Python version. But, as you can see from the images I posted, |
@zanieb Friendly reminder. |
@Tsafaras On your first image example you're using the distroless image which is not supported in Gitlab as We do not have custom entrypoints on any of the non-distroless images. The distroless does and defaults to uv as it's the only binary in that container image. e.g. Non-Distroless ~/ $ docker inspect ghcr.io/astral-sh/uv:0.5-python3.8-bookworm | jq -r '.[0].Config.Entrypoint'
null Distroless ~/ $ docker inspect ghcr.io/astral-sh/uv:0.5 | jq -r '.[0].Config.Entrypoint'
[
"/uv"
] |
@samypr100 Thank you for the response, especially for the last snippet! Should I edit the PR to make this change in the relative docs then?
|
I think it's worth adding a note to the gitlab docs, thanks |
Update the docs for the GitLab integration, to make it clear that an entrypoint has to be specified, when a distroless image is being used.
@samypr100 @zanieb Turned the correction to a note. Please have a look. |
@zanieb Friendly reminder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.5.6` -> `0.5.7` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.5.7`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#057) [Compare Source](astral-sh/uv@0.5.6...0.5.7) ##### Enhancements - Ignore dynamic version in source dist ([#​9549](astral-sh/uv#9549)) - Improve build frontend error handling ([#​9611](astral-sh/uv#9611)) - Un-hide `uv build --no-build-logs` option ([#​9642](astral-sh/uv#9642)) - Flag version mismatch between sdist and wheel during `uv build` ([#​9633](astral-sh/uv#9633)) - Improve message when updater receipt is for a different uv executable ([#​9487](astral-sh/uv#9487)) - Add environment variable to disable writing installer metadata files ([#​8877](astral-sh/uv#8877)) - Add managed downloads for the latest CPython releases: `3.9.21`, `3.10.16`, `3.11.11`, `3.12.8`, and `3.13.1` ([#​9696](astral-sh/uv#9696)) ##### Preview features - Build backend: Add hint on import with preview disabled ([#​9691](astral-sh/uv#9691)) - Build backend: Add direct builds to the resolver and installer ([#​9621](astral-sh/uv#9621)) - Build backend: Add integration test for scripts ([#​9635](astral-sh/uv#9635)) - Build backend: Add template to `uv init` ([#​9661](astral-sh/uv#9661)) - Build backend: Add `--list` option ([#​9610](astral-sh/uv#9610)) ##### Bug fixes - Create missing parent directories for output file of `uv export` / `uv pip compile` ([#​9648](astral-sh/uv#9648)) - Fix missing display of non-freethreaded Python 3.13 in `python list` ([#​9669](astral-sh/uv#9669)) - Implement `Ord` and `PartialOrd` without origin for `Requirement` ([#​9624](astral-sh/uv#9624)) - Include more sources to avoid lowest bound warning ([#​9644](astral-sh/uv#9644)) - Respect build tag priority in `uv.lock` ([#​9677](astral-sh/uv#9677)) ##### Documentation - Add `build-essentials` note to build failures doc ([#​9641](astral-sh/uv#9641)) - Add entry-point for distroless image in GitLab documentation ([#​9093](astral-sh/uv#9093)) - Add documentation for `uv python pin` without a `REQUEST` argument ([#​9631](astral-sh/uv#9631)) - Add a link to `uv python pin` reference docs ([#​9630](astral-sh/uv#9630)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Summary
Update the docs for the GitLab integration, to make it clear that an entrypoint has to be specified, when a distroless image is being used.
Test Plan
Without specifying an entrypoint when using a distroless image:
It works if you either specify the entrypoint or if the image used in not a distroless one.