Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs(GitLab): add entrypoint for distroless image #9093

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

Tsafaras
Copy link
Contributor

@Tsafaras Tsafaras commented Nov 13, 2024

Summary

Update the docs for the GitLab integration, to make it clear that an entrypoint has to be specified, when a distroless image is being used.

Test Plan

Without specifying an entrypoint when using a distroless image:

It works if you either specify the entrypoint or if the image used in not a distroless one.

@zanieb
Copy link
Member

zanieb commented Nov 13, 2024

Hm I thought we removed the custom entrypoint in #7054

@Tsafaras
Copy link
Contributor Author

Tsafaras commented Nov 13, 2024

This is the image I used:

ghcr.io/astral-sh/uv:python3.8-bookworm

Could this be why? My project is still using that Python version.

But, as you can see from the images I posted, uv's version is latest (0.5.1).
Could also have something to do with GitLab and not with uv.

@Tsafaras
Copy link
Contributor Author

@zanieb Friendly reminder.
Let me know how you want to move on this.

@samypr100
Copy link
Collaborator

samypr100 commented Nov 21, 2024

@Tsafaras On your first image example you're using the distroless image which is not supported in Gitlab as sh does not exist in it. That's actually one of the reason the non-distroless images were added 😄

We do not have custom entrypoints on any of the non-distroless images. The distroless does and defaults to uv as it's the only binary in that container image.

e.g.

Non-Distroless

~/ $ docker inspect ghcr.io/astral-sh/uv:0.5-python3.8-bookworm | jq  -r '.[0].Config.Entrypoint'
null

Distroless

~/ $ docker inspect ghcr.io/astral-sh/uv:0.5 | jq  -r '.[0].Config.Entrypoint'
[
  "/uv"
]

@Tsafaras
Copy link
Contributor Author

Tsafaras commented Nov 21, 2024

@samypr100 Thank you for the response, especially for the last snippet!
I tried finding something similar as to what you can see on docker hub (example), but I didn't find it on GH's registry. 🤔
In between tests I never considered I had changed the image.

Should I edit the PR to make this change in the relative docs then?

If you're using a distroless image ... blah blah

@samypr100
Copy link
Collaborator

Should I edit the PR to make this change in the relative docs then?

I think it's worth adding a note to the gitlab docs, thanks

Update the docs for the GitLab integration, to make it clear that an entrypoint
has to be specified, when a distroless image is being used.
@Tsafaras
Copy link
Contributor Author

@samypr100 @zanieb Turned the correction to a note. Please have a look.

@zanieb zanieb added the documentation Improvements or additions to documentation label Nov 21, 2024
@Tsafaras Tsafaras changed the title Docs: missing entrypoint in gitlab integration Docs(GitLab): add entrypoint for distroless image Nov 22, 2024
@Tsafaras
Copy link
Contributor Author

Tsafaras commented Dec 3, 2024

@zanieb Friendly reminder.

Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zanieb zanieb merged commit 7d13088 into astral-sh:main Dec 4, 2024
53 checks passed
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Dec 9, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.5.6` -> `0.5.7` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>astral-sh/uv (astral-sh/uv)</summary>

### [`v0.5.7`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#057)

[Compare Source](astral-sh/uv@0.5.6...0.5.7)

##### Enhancements

-   Ignore dynamic version in source dist ([#&#8203;9549](astral-sh/uv#9549))
-   Improve build frontend error handling ([#&#8203;9611](astral-sh/uv#9611))
-   Un-hide `uv build --no-build-logs` option ([#&#8203;9642](astral-sh/uv#9642))
-   Flag version mismatch between sdist and wheel during `uv build` ([#&#8203;9633](astral-sh/uv#9633))
-   Improve message when updater receipt is for a different uv executable ([#&#8203;9487](astral-sh/uv#9487))
-   Add environment variable to disable writing installer metadata files ([#&#8203;8877](astral-sh/uv#8877))
-   Add managed downloads for the latest CPython releases: `3.9.21`, `3.10.16`, `3.11.11`, `3.12.8`, and `3.13.1` ([#&#8203;9696](astral-sh/uv#9696))

##### Preview features

-   Build backend: Add hint on import with preview disabled ([#&#8203;9691](astral-sh/uv#9691))
-   Build backend: Add direct builds to the resolver and installer ([#&#8203;9621](astral-sh/uv#9621))
-   Build backend: Add integration test for scripts ([#&#8203;9635](astral-sh/uv#9635))
-   Build backend: Add template to `uv init` ([#&#8203;9661](astral-sh/uv#9661))
-   Build backend: Add `--list` option ([#&#8203;9610](astral-sh/uv#9610))

##### Bug fixes

-   Create missing parent directories for output file of `uv export` / `uv pip compile` ([#&#8203;9648](astral-sh/uv#9648))
-   Fix missing display of non-freethreaded Python 3.13 in `python list` ([#&#8203;9669](astral-sh/uv#9669))
-   Implement `Ord` and `PartialOrd` without origin for `Requirement` ([#&#8203;9624](astral-sh/uv#9624))
-   Include more sources to avoid lowest bound warning ([#&#8203;9644](astral-sh/uv#9644))
-   Respect build tag priority in `uv.lock` ([#&#8203;9677](astral-sh/uv#9677))

##### Documentation

-   Add `build-essentials` note to build failures doc ([#&#8203;9641](astral-sh/uv#9641))
-   Add entry-point for distroless image in GitLab documentation ([#&#8203;9093](astral-sh/uv#9093))
-   Add documentation for `uv python pin` without a `REQUEST` argument ([#&#8203;9631](astral-sh/uv#9631))
-   Add a link to `uv python pin` reference docs ([#&#8203;9630](astral-sh/uv#9630))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants