Skip to content

Commit

Permalink
Rewrite test_jsonify_aware_datetimes without pytz
Browse files Browse the repository at this point in the history
  • Loading branch information
Eugene M. Kim committed Jun 14, 2017
1 parent d41e2e6 commit 0e6cab3
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 9 deletions.
15 changes: 7 additions & 8 deletions tests/test_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
from werkzeug.http import http_date
from flask._compat import StringIO, text_type
from flask.helpers import get_debug_flag, make_response
from pytz import timezone


def has_encoding(name):
Expand Down Expand Up @@ -178,14 +177,14 @@ def test_jsonify_date_types(self, app, client):
assert rv.mimetype == 'application/json'
assert flask.json.loads(rv.data)['x'] == http_date(d.timetuple())

@pytest.mark.parametrize('tzname', ('UTC', 'PST8PDT', 'Asia/Seoul'))
def test_jsonify_aware_datetimes(self, tzname):
@pytest.mark.parametrize('tz', (('UTC', 0), ('PST', -8), ('KST', 9)))
def test_jsonify_aware_datetimes(self, tz):
"""Test if aware datetime.datetime objects are converted into GMT."""
dt_naive = datetime.datetime(2017, 1, 1, 12, 34, 56)
dt_aware = timezone(tzname).localize(dt_naive)
dt_as_gmt = dt_aware.astimezone(timezone('GMT'))
expected = dt_as_gmt.strftime('"%a, %d %b %Y %H:%M:%S %Z"')
assert flask.json.JSONEncoder().encode(dt_aware) == expected
tzinfo = datetime.timezone(datetime.timedelta(hours=tz[1]), name=tz[0])
dt = datetime.datetime(2017, 1, 1, 12, 34, 56, tzinfo=tzinfo)
gmt = datetime.timezone(datetime.timedelta(), name='GMT')
expected = dt.astimezone(gmt).strftime('"%a, %d %b %Y %H:%M:%S %Z"')
assert flask.json.JSONEncoder().encode(dt) == expected

def test_jsonify_uuid_types(self, app, client):
"""Test jsonify with uuid.UUID types"""
Expand Down
1 change: 0 additions & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ deps =
coverage
greenlet
blinker
pytz

lowest: Werkzeug==0.9
lowest: Jinja2==2.4
Expand Down

0 comments on commit 0e6cab3

Please sign in to comment.