Skip to content

Commit

Permalink
Add UTs for pallets#2372
Browse files Browse the repository at this point in the history
test_encode_aware_datetime() fails for non-UTC timezones due to the bug.
  • Loading branch information
Eugene M. Kim committed Jun 14, 2017
1 parent 2c97ed9 commit d75d83d
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
10 changes: 10 additions & 0 deletions tests/test_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
from werkzeug.http import http_date
from flask._compat import StringIO, text_type
from flask.helpers import get_debug_flag, make_response
from pytz import timezone


def has_encoding(name):
Expand Down Expand Up @@ -177,6 +178,15 @@ def test_jsonify_date_types(self, app, client):
assert rv.mimetype == 'application/json'
assert flask.json.loads(rv.data)['x'] == http_date(d.timetuple())

@pytest.mark.parametrize('tzname', ('UTC', 'PST8PDT', 'Asia/Seoul'))
def test_jsonify_aware_datetimes(self, tzname):
"""Test if aware datetime.datetime objects are converted into GMT."""
dt_naive = datetime.datetime(2017, 1, 1, 12, 34, 56)
dt_aware = timezone(tzname).localize(dt_naive)
dt_as_gmt = dt_aware.astimezone(timezone('GMT'))
expected = dt_as_gmt.strftime('"%a, %d %b %Y %H:%M:%S %Z"')
assert flask.json.JSONEncoder().encode(dt_aware) == expected

def test_jsonify_uuid_types(self, app, client):
"""Test jsonify with uuid.UUID types"""

Expand Down
1 change: 1 addition & 0 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ deps =
coverage
greenlet
blinker
pytz

lowest: Werkzeug==0.9
lowest: Jinja2==2.4
Expand Down

0 comments on commit d75d83d

Please sign in to comment.