Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XERC20 token implementation #124

Merged
merged 3 commits into from
Dec 17, 2024
Merged

XERC20 token implementation #124

merged 3 commits into from
Dec 17, 2024

Conversation

EgeCaner
Copy link
Contributor

Scope

  • XERC20 token implementation
  • XERC20Lockbox implementation
  • XERC20Factory implementation

Differences from solidity implementation

Deployment pattern

Solidity implementation uses CREATE3 to be able to deploy different implementation on same address among multiple EVM chains. Since we cannot have same addresses with EVM chains this pattern is not applied.

Upgradeability

In Solidity implementation none of these contracts are upgradeable!

  • In Cairo implementation xerc20 and lockbox is upgradeable to be more future proof.
    • Only owner of xerc20 can upgrade implementation of xerc20 and lockbox.
  • xerc20 and lockbox implementation factory deploys can be updated with new class hashes in the future.

@JordyRo1 JordyRo1 self-requested a review December 17, 2024 16:11
@JordyRo1 JordyRo1 merged commit 563426e into astraly-labs:main Dec 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants