Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Differences from solidity implementation
Deployment pattern
Solidity implementation uses
CREATE3
to be able to deploy different implementation on same address among multiple EVM chains. Since we cannot have same addresses with EVM chains this pattern is not applied.Upgradeability
In Solidity implementation none of these contracts are upgradeable!
xerc20
andlockbox
is upgradeable to be more future proof.xerc20
andlockbox
implementation factory deploys can be updated with new class hashes in the future.