Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add domain routing hook #38

Merged
merged 15 commits into from
Dec 17, 2024
Merged

feat: add domain routing hook #38

merged 15 commits into from
Dec 17, 2024

Conversation

Xavek
Copy link
Contributor

@Xavek Xavek commented Jun 17, 2024

Implements #29

EvolveArt
EvolveArt reviewed Jun 17, 2024
View reviewed changes
Copy link
Contributor

@EvolveArt EvolveArt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol comment will let @JordyRo1 give a detailled review

contracts/src/interfaces.cairo Outdated Show resolved Hide resolved
contracts/src/interfaces.cairo Outdated Show resolved Hide resolved
@JordyRo1
Copy link
Contributor

JordyRo1 commented Jun 18, 2024 •
edited
Loading

Hi, can you add some test coverage for your contract, please ? You can deploy your contract by defining a function in the setup.cairo (cf: https://github.com/astraly-labs/hyperlane_starknet/blob/main/contracts/src/tests/setup.cairo). You can use setup_mock_hook to deploy a mock hook for your testing. Regarding the code you already wrote, everything looks good at first sight, nice job !

@EvolveArt EvolveArt changed the title add domain routing hook feat: add domain routing hook Jun 18, 2024
@Xavek
Copy link
Contributor Author

Xavek commented Jun 20, 2024

@JordyRo1 Tried to add tests. Can you have a look now

@Xavek Xavek requested a review from EvolveArt June 20, 2024 11:46
@EvolveArt EvolveArt requested a review from JordyRo1 June 20, 2024 12:41
@Xavek Xavek requested a review from JordyRo1 June 26, 2024 08:18
@JordyRo1
Copy link
Contributor

Reviewed. The general hook idea is understood, everything seems fine !

@Xavek Xavek requested a review from JordyRo1 July 1, 2024 16:35
@EvolveArt EvolveArt marked this pull request as ready for review December 11, 2024 09:20
@JordyRo1 JordyRo1 merged commit 2b4f509 into astraly-labs:main Dec 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordyRo1 JordyRo1 JordyRo1 approved these changes

@EvolveArt EvolveArt Awaiting requested review from EvolveArt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xavek @JordyRo1 @EvolveArt