Fixed FilesystemPath::isFile return value.

FilesystemPath::isFile was changed to return the result of it not being a directory and if it exists. Resolves avast#490
astrelsky · Feb 5, 2019 · d78a6c3 · d78a6c3
1 parent 6e6c609
commit d78a6c3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,7 +1,8 @@
 # Changelog
 
 # dev
-
+* Fix: Modified FilesystemPath::isFile to return true only when the file also exists. ([#490]
+(https://github.com/avast-tl/retdec/issues/490)).
 * Fix: Added option to `retdec-bin2pat` to have the objects list passed through a text file.
 Modified `retdec-signature-from-library-creator.py` to pass objects list as a text file. ([#472](https://github.com/avast-tl/retdec/issues/472)).
 * New Feature: Added presentation of imported types and TypeRef hashes for .NET binaries ([#363](https://github.com/avast-tl/retdec/issues/363), [#364](https://github.com/avast-tl/retdec/issues/364), [#428](https://github.com/avast-tl/retdec/issues/428)).

diff --git a/src/utils/filesystem_path.cpp b/src/utils/filesystem_path.cpp
@@ -390,7 +390,7 @@ bool FilesystemPath::isDirectory() const
  */
 bool FilesystemPath::isFile() const
 {
-	return _impl->isFile();
+	return _impl->isFile() && _impl->exists();
 }
 
 /**