Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sequencer: move all ActionHandler impls to a central location #1657

Closed
Tracked by #1810
ethanoroshiba opened this issue Oct 15, 2024 · 0 comments · Fixed by #1759
Closed
Tracked by #1810

sequencer: move all ActionHandler impls to a central location #1657

ethanoroshiba opened this issue Oct 15, 2024 · 0 comments · Fixed by #1759
Assignees
Labels
code-quality sequencer pertaining to the astria-sequencer crate

Comments

@ethanoroshiba
Copy link
Contributor

ethanoroshiba commented Oct 15, 2024

As mentioned here, we should move all ActionHandler impls to a central location.

┆Issue Number: ENG-917

@ethanoroshiba ethanoroshiba added sequencer pertaining to the astria-sequencer crate code-quality labels Oct 15, 2024
@ethanoroshiba ethanoroshiba self-assigned this Oct 15, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 2, 2024
## Summary
Moved all action and transaction handling to single module.

## Background
Previously, all implementations of `ActionHandler` were done separately
in components which corresponded to their given actions (or groups of
actions, such as in `bridge`). While this may make sense from an
action-centered point of view, it is confusing to an outsider to have to
look many different places to find where stateless/stateful checks and
execution occur. This PR consolidates all of the implementations as well
as their testing.

## Changes
- Created new `action_handler` module and moved the corresponding
`ActionHandler` trait as well as all of its `impl`s into this module.
- Renamed some moved tests for clarity.
- Categorized tests by action in submodule `tests`.
- Categorized impls by action in submodule `impls`.

## Testing
Passing all tests.

## Changelogs
Changelogs updated

## Related Issues
closes #1657
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality sequencer pertaining to the astria-sequencer crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant