chore(cli)!: default to dusk-11 #1755
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joroshiba
changed the title
Fraser999
approved these changes
Nov 14, 2024
SuperFluffy
reviewed
Nov 14, 2024
There was a problem hiding this comment.
This PR clashes with #1792, which seeks to remove the defaults altogether.
If we choose to distribute a binary that talks to mainnet, then that should be done via a config file that we ship along the binary, but not as a default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the CLI to work with a production network by default
Background
The CLI has continued to default to dusk-10 and had an old env var name that didn't make sense for chain id without rollup code inside.
Changes
Breaking Changelist
ROLLUP_SEQUENCER_CHAIN_IDtoSEQUENCER_CHAIN_IDTesting
N/A
Changelogs
Changelogs updated.