feat(sequencer): store currency pair id mapping along with committed extended commit info #1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
proto
Fraser999
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
This looks correct to me, but I'd like to see a test for the new validation functionality provided by validate_id_to_currency_pair_mapping. However, as discussed offline, this is probably best done on top of the noot/more-tests branch where there are a bunch of other fixes and additional tests, so I'm fine to merge this, then prioritise adding the test into that branch and opening a PR.
Comment on lines
+143
to
+147
| let extended_commit_info = ExtendedCommitInfo::try_from( | ||
| <astria_vendored::tendermint::abci::ExtendedCommitInfo as Into< | ||
| tendermint_proto::abci::ExtendedCommitInfo, | ||
| >>::into(extended_commit_info), | ||
| ) |
There was a problem hiding this comment.
Suggested change
| let extended_commit_info = ExtendedCommitInfo::try_from( | |
| <astria_vendored::tendermint::abci::ExtendedCommitInfo as Into< | |
| tendermint_proto::abci::ExtendedCommitInfo, | |
| >>::into(extended_commit_info), | |
| ) | |
| let extended_commit_info = ExtendedCommitInfo::try_from( | |
| tendermint_proto::abci::ExtendedCommitInfo::from(extended_commit_info), | |
| ) |
Comment on lines
+115
to
+123
| #[must_use] | ||
| pub fn extended_commit_info(&self) -> &ExtendedCommitInfo { | ||
| &self.extended_commit_info | ||
| } | ||
|
|
||
| #[must_use] | ||
| pub fn id_to_currency_pair(&self) -> &IndexMap<CurrencyPairId, CurrencyPair> { | ||
| &self.id_to_currency_pair | ||
| } |
There was a problem hiding this comment.
I'd remove these two getters as the struct's fields are public.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
the price data posted by validators is of the form currency pair ID -> price, however when this is sent to a rollup there is then no way to determine the ID -> actual currency pair without referencing the sequencer state. this is non ideal as we don't want to have to perform lookups using a sequencer node for the oracle data.
Background
see above
Changes
ExtendedCommitInfoWithCurrencyPairMappingtype which containsExtendedCommitInfo(as previous) as well as the ID->currency pair mapping for the price data inside thatExtendedCommitInfoExtendedCommitInfoWithCurrencyPairMappingis then used as the third injected tx in the block, whereas before it was justExtendedCommitInfoprocess_proposalTesting
unit tests + CI tests
Related Issues
required for #1818