Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

set entire ingress spec to configurable var #109

Merged
merged 7 commits into from
Oct 12, 2023
Merged

set entire ingress spec to configurable var #109

merged 7 commits into from
Oct 12, 2023

Conversation

WafflesVonMaple
Copy link
Contributor

@WafflesVonMaple WafflesVonMaple commented Oct 11, 2023 •
edited
Loading

Solves #92

@steezeburger steezeburger mentioned this pull request Oct 11, 2023
Closed
@WafflesVonMaple WafflesVonMaple self-assigned this Oct 12, 2023
@WafflesVonMaple WafflesVonMaple marked this pull request as ready for review October 12, 2023 20:28
joroshiba
joroshiba approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@joroshiba joroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some new lines to be added.

helm/sequencer-faucet/values.yaml Outdated Show resolved Hide resolved
helm/sequencer/templates/_helpers.tpl Outdated Show resolved Hide resolved
helm/sequencer/values.yaml Outdated Show resolved Hide resolved
@WafflesVonMaple WafflesVonMaple merged commit e0a7641 into main Oct 12, 2023
@WafflesVonMaple WafflesVonMaple deleted the ingress_template branch October 12, 2023 20:43
steezeburger added a commit that referenced this pull request Oct 16, 2023
@steezeburger
Merge branch 'main' into gh-pages
b7496c5 
* main:
  Update images for conductor, composer (#114)
  fix(just): just commands didn't work after chart reorg (#113)
  init lint, set base maintainer (#111)
  fix ingress host tpl (#112)
  set entire ingress spec to configurable var (#109)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joroshiba joroshiba joroshiba approved these changes

@steezeburger steezeburger Awaiting requested review from steezeburger

Assignees

@WafflesVonMaple WafflesVonMaple

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WafflesVonMaple @joroshiba