This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
Cometbft: enable prometheus exporter #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WafflesVonMaple
changed the title
|
@joroshiba worth chatting on this one since we are kinda crafting cometbft ourselves here. Worth looking at cometbft/cometbft#899 |
WafflesVonMaple
commented
Jan 5, 2024
joroshiba
suggested changes
Jan 5, 2024
| namespace: {{ .Values.global.namespace }} | ||
| spec: | ||
| selector: | ||
| app: {{ .Values.config.moniker }}-sequencer |
There was a problem hiding this comment.
Do we need to update this and other areas to use the new helpers name and labels?
There was a problem hiding this comment.
we dont have to do it this way at all either, was just a fast way to ensure service monitor selectors picked up the right app name
joroshiba
approved these changes
Jan 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.