This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
Geth: enable prometheus metric on start-geth + service monitor template #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WafflesVonMaple
requested review from
joroshiba and
steezeburger
and removed request for
joroshiba
WafflesVonMaple
force-pushed
the
geth_prometheus
branch
from
138f92a
to
96d9454
Compare
added 2 commits
January 5, 2024 13:42
WafflesVonMaple
changed the title
joroshiba
suggested changes
Jan 6, 2024
| Common labels | ||
| */}} | ||
| {{- define "rollup.labels" -}} | ||
| {{ include "rollup.selectorLabels" . }} |
There was a problem hiding this comment.
why have the seperate labels if it just includes selector labels?
There was a problem hiding this comment.
not necessary, just makes easy to merge both if we have complicated labels or selector
added 2 commits
January 8, 2024 13:58
joroshiba
approved these changes
Jan 9, 2024
| {{ if .Values.config.rollup.archiveNode }}--gcmode "archive" --txlookuplimit "0" {{- end }} | ||
| {{ if .Values.config.rollup.archiveNode }}--gcmode "archive" --txlookuplimit "0" {{- end }} \ | ||
| {{ if .Values.config.rollup.metrics.enabled }} --metrics --metrics.addr "0.0.0.0" --metrics.port {{ .Values.ports.metrics }} {{- end }} | ||
|
|
There was a problem hiding this comment.
I think you might have some spaces on this line
There was a problem hiding this comment.
fixed you were correct between 0" --metrics
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.