Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

updating to newest release versions #179

Merged
merged 18 commits into from
Mar 11, 2024
Merged

updating to newest release versions #179

merged 18 commits into from
Mar 11, 2024

Conversation

joroshiba
Copy link
Member

@joroshiba joroshiba commented Feb 15, 2024

This is a wide sweeping PR with many updates two overarching goals:

  • Update dev-cluster to make latest work with dev-cluster
  • Enable managing "release" charts and "development" within a single chart.

Additionally there have been some changes to make charts more generically semantically correct and changes made during debug process which will hopefully aid future development.

The core of these changes are adding to our main charts a .Values.global.dev flag which defaults to false. There is then a pattern setup through out the charts to manage dev pieces, such as images and the more various configuration changes.

Image tags have been split up to now feature a tag and devTag field. The goal should be for the charts to work with our latest produced images at all times. In places where we have changes in chart and configuration required for latest we use the following pattern to make updating for new releases easy:

{{ if not .Values.global.dev }}
< Anything which should be removed when next release is cut >
{{ else }}
< Anything which becomes standard when next release is cut >
{{ end }}

Additional changes:

  • utilize .Release.namespace as default, moving .Values.global.namespace to .Values.global.namespaceOverride
  • Added a k8s file for metrics server which can run locally
  • Added resource limit configuration for rollup
  • Simplified Rollup definition to no longer have a chainId and a name matching changes made in monorepo to disambiguate chainId
  • disable peering for geth node
  • update the celestia-local configuration to be less noisy, more useful for debugging in test environment

@aajimal aajimal added preview and removed preview labels Mar 1, 2024
Comment on lines +18 to +19
sed -i 's/PeersLimit = 5/PeersLimit = 1/' $home_dir/bridge/config.toml
sed -i 's/Low = 50/Low = 0/' $home_dir/bridge/config.toml
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need celestia local to have any peers, it shouldnt have any it's a one off instance.

Comment on lines +63 to +64
--log.level "debug" \
--log.level.module "share/discovery:error"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaning up logs, and removing share discovery warnings about no networking, cleaner logs in case there is a celestia local issue.

Comment on lines +88 to +94
resources:
requests:
cpu: 1
memory: 4Gi
limits:
cpu: 2
memory: 8Gi
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contraining bridge node on dev cluster since it can be an expensive service to run.

@@ -0,0 +1,53 @@
apiVersion: networking.k8s.io/v1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added ingress which makes it possible to communicate directly with deployed Celestia app and bridge node from local machine.

type: light
coreGrpcPort: 9090
tokenAuthLevel: 'read'
customInfo: ''
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more technically correct, still falsey.

Comment on lines +22 to +29
{{- if not .Values.global.dev }}
"astriaDataAvailabilityInitialHeight": {{ .Values.config.celestia.initialBlockHeight }},
"astriaDataAvailabilityHeightVariance": {{ .Values.config.celestia.heightVariance }}
{{- else }}
"astriaRollupName": "{{ .Values.config.rollup.name }}",
"astriaCelestiaInitialHeight": {{ .Values.config.celestia.initialBlockHeight }},
"astriaCelestiaHeightVariance": {{ .Values.config.celestia.heightVariance }}
{{- end }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note pattern used throughout for configuration which might change between releases.

@joroshiba joroshiba marked this pull request as ready for review March 11, 2024 18:38
Copy link
Contributor

@WafflesVonMaple WafflesVonMaple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

@joroshiba joroshiba merged commit c8cb074 into main Mar 11, 2024
1 check passed
@joroshiba joroshiba deleted the joroshiba/broad-updates branch March 11, 2024 19:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants