-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
89058f0
to
b2dea44
Compare
sed -i 's/PeersLimit = 5/PeersLimit = 1/' $home_dir/bridge/config.toml | ||
sed -i 's/Low = 50/Low = 0/' $home_dir/bridge/config.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need celestia local to have any peers, it shouldnt have any it's a one off instance.
--log.level "debug" \ | ||
--log.level.module "share/discovery:error" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleaning up logs, and removing share discovery warnings about no networking, cleaner logs in case there is a celestia local issue.
resources: | ||
requests: | ||
cpu: 1 | ||
memory: 4Gi | ||
limits: | ||
cpu: 2 | ||
memory: 8Gi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contraining bridge node on dev cluster since it can be an expensive service to run.
@@ -0,0 +1,53 @@ | |||
apiVersion: networking.k8s.io/v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added ingress which makes it possible to communicate directly with deployed Celestia app and bridge node from local machine.
type: light | ||
coreGrpcPort: 9090 | ||
tokenAuthLevel: 'read' | ||
customInfo: '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more technically correct, still falsey.
{{- if not .Values.global.dev }} | ||
"astriaDataAvailabilityInitialHeight": {{ .Values.config.celestia.initialBlockHeight }}, | ||
"astriaDataAvailabilityHeightVariance": {{ .Values.config.celestia.heightVariance }} | ||
{{- else }} | ||
"astriaRollupName": "{{ .Values.config.rollup.name }}", | ||
"astriaCelestiaInitialHeight": {{ .Values.config.celestia.initialBlockHeight }}, | ||
"astriaCelestiaHeightVariance": {{ .Values.config.celestia.heightVariance }} | ||
{{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note pattern used throughout for configuration which might change between releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful
This is a wide sweeping PR with many updates two overarching goals:
Additionally there have been some changes to make charts more generically semantically correct and changes made during debug process which will hopefully aid future development.
The core of these changes are adding to our main charts a
.Values.global.dev
flag which defaults to false. There is then a pattern setup through out the charts to manage dev pieces, such as images and the more various configuration changes.Image tags have been split up to now feature a
tag
anddevTag
field. The goal should be for the charts to work with our latest produced images at all times. In places where we have changes in chart and configuration required for latest we use the following pattern to make updating for new releases easy:Additional changes:
.Release.namespace
as default, moving.Values.global.namespace
to.Values.global.namespaceOverride
chainId
and aname
matching changes made in monorepo to disambiguatechainId