Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update protos #10

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Chore: Update protos #10

merged 2 commits into from
Apr 26, 2024

Conversation

sambukowski
Copy link
Contributor

No description provided.

@steezeburger
Copy link
Member

steezeburger commented Apr 26, 2024

Tests didn't pass for me

--- FAIL: TestSignAndBroadcastTx (0.27s)
    client_test.go:48:
        	Error Trace:	/code/astria/repos/go-sequencer-client/client/client_test.go:48
        	Error:      	Not equal:
        	            	expected: 0x0
        	            	actual  : 0x2
        	Test:       	TestSignAndBroadcastTx
        	Messages:   	DecodeError { description: "invalid wire type: LengthDelimited (expected Varint)", stack: [("UnsignedTransaction", "nonce"), ("SignedTransaction", "transaction")] }

client/client_test.go Outdated Show resolved Hide resolved
@joroshiba
Copy link
Member

Tests didn't pass for me

--- FAIL: TestSignAndBroadcastTx (0.27s)
    client_test.go:48:
        	Error Trace:	/code/astria/repos/go-sequencer-client/client/client_test.go:48
        	Error:      	Not equal:
        	            	expected: 0x0
        	            	actual  : 0x2
        	Test:       	TestSignAndBroadcastTx
        	Messages:   	DecodeError { description: "invalid wire type: LengthDelimited (expected Varint)", stack: [("UnsignedTransaction", "nonce"), ("SignedTransaction", "transaction")] }

Likely running against wrong version of sequencer, we changed the core transaction shape. New binaries and images just cut. Might be easiest to test against the mono repo smoke test setup instead of localhost?

but also.... don't think this test will ever pass, it will always fail checktx because there is no balance in the account.

Copy link
Member

@joroshiba joroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sambukowski sambukowski merged commit 92c3f4e into master Apr 26, 2024
@sambukowski sambukowski deleted the chore/update-protos branch April 26, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants