Skip to content

merge with upstream

merge with upstream #1

GitHub Actions / clippy-no-default-features failed Jan 17, 2024 in 0s

clippy-no-default-features

44 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 44
Warning 0
Note 0
Help 0

Versions

  • rustc 1.75.0 (82e1608df 2023-12-21)
  • cargo 1.75.0 (1d8b05cdd 2023-11-20)
  • clippy 0.1.75 (82e1608 2023-12-21)

Annotations

Check failure on line 25 in crates/relayer/src/chain/astria/utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

use of a fallible conversion when an infallible one could be used

error: use of a fallible conversion when an infallible one could be used
  --> crates/relayer/src/chain/astria/utils.rs:25:10
   |
25 |         .try_into()
   |          ^^^^^^^^ help: use: `into`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
   = note: `-D clippy::unnecessary-fallible-conversions` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::unnecessary_fallible_conversions)]`

Check failure on line 212 in crates/relayer/src/transfer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

redundant field names in struct initialization

error: redundant field names in struct initialization
   --> crates/relayer/src/transfer.rs:212:9
    |
212 |         denom: denom,
    |         ^^^^^^^^^^^^ help: replace it with: `denom`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
    = note: `-D clippy::redundant-field-names` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::redundant_field_names)]`

Check failure on line 501 in crates/relayer/src/event.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

unused imports: `ics04_channel::packet::Sequence`, `timestamp::Timestamp`

error: unused imports: `ics04_channel::packet::Sequence`, `timestamp::Timestamp`
   --> crates/relayer/src/event.rs:501:13
    |
501 |             ics04_channel::packet::Sequence,
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
502 |         },
503 |         timestamp::Timestamp,
    |         ^^^^^^^^^^^^^^^^^^^^
    |
    = note: `-D unused-imports` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(unused_imports)]`

Check failure on line 592 in crates/relayer/src/event.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

failed to resolve: use of undeclared type `ChannelAttributes`

error[E0433]: failed to resolve: use of undeclared type `ChannelAttributes`
   --> crates/relayer/src/event.rs:592:36
    |
592 |                         assert_eq!(ChannelAttributes::from(e), close_confirm.clone().into())
    |                                    ^^^^^^^^^^^^^^^^^ use of undeclared type `ChannelAttributes`
    |
help: consider importing this struct through its public re-export
    |
490 +     use crate::event::ChannelAttributes;
    |

Check failure on line 591 in crates/relayer/src/event.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

failed to resolve: use of undeclared type `IbcEvent`

error[E0433]: failed to resolve: use of undeclared type `IbcEvent`
   --> crates/relayer/src/event.rs:591:21
    |
591 |                     IbcEvent::CloseConfirmChannel(e) => {
    |                     ^^^^^^^^ use of undeclared type `IbcEvent`
    |
help: consider importing one of these items
    |
490 +     use crate::event::IbcEvent;
    |
490 +     use ibc_relayer_types::events::IbcEvent;
    |

Check failure on line 589 in crates/relayer/src/event.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

failed to resolve: use of undeclared type `ChannelAttributes`

error[E0433]: failed to resolve: use of undeclared type `ChannelAttributes`
   --> crates/relayer/src/event.rs:589:36
    |
589 |                         assert_eq!(ChannelAttributes::from(e), close_init.clone().into())
    |                                    ^^^^^^^^^^^^^^^^^ use of undeclared type `ChannelAttributes`
    |
help: consider importing this struct through its public re-export
    |
490 +     use crate::event::ChannelAttributes;
    |

Check failure on line 588 in crates/relayer/src/event.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

failed to resolve: use of undeclared type `IbcEvent`

error[E0433]: failed to resolve: use of undeclared type `IbcEvent`
   --> crates/relayer/src/event.rs:588:21
    |
588 |                     IbcEvent::CloseInitChannel(e) => {
    |                     ^^^^^^^^ use of undeclared type `IbcEvent`
    |
help: consider importing one of these items
    |
490 +     use crate::event::IbcEvent;
    |
490 +     use ibc_relayer_types::events::IbcEvent;
    |

Check failure on line 586 in crates/relayer/src/event.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

failed to resolve: use of undeclared type `ChannelAttributes`

error[E0433]: failed to resolve: use of undeclared type `ChannelAttributes`
   --> crates/relayer/src/event.rs:586:36
    |
586 |                         assert_eq!(ChannelAttributes::from(e), open_confirm.clone().into())
    |                                    ^^^^^^^^^^^^^^^^^ use of undeclared type `ChannelAttributes`
    |
help: consider importing this struct through its public re-export
    |
490 +     use crate::event::ChannelAttributes;
    |

Check failure on line 585 in crates/relayer/src/event.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

failed to resolve: use of undeclared type `IbcEvent`

error[E0433]: failed to resolve: use of undeclared type `IbcEvent`
   --> crates/relayer/src/event.rs:585:21
    |
585 |                     IbcEvent::OpenConfirmChannel(e) => {
    |                     ^^^^^^^^ use of undeclared type `IbcEvent`
    |
help: consider importing one of these items
    |
490 +     use crate::event::IbcEvent;
    |
490 +     use ibc_relayer_types::events::IbcEvent;
    |

Check failure on line 583 in crates/relayer/src/event.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

failed to resolve: use of undeclared type `ChannelAttributes`

error[E0433]: failed to resolve: use of undeclared type `ChannelAttributes`
   --> crates/relayer/src/event.rs:583:36
    |
583 |                         assert_eq!(ChannelAttributes::from(e), open_ack.clone().into())
    |                                    ^^^^^^^^^^^^^^^^^ use of undeclared type `ChannelAttributes`
    |
help: consider importing this struct through its public re-export
    |
490 +     use crate::event::ChannelAttributes;
    |

Check failure on line 582 in crates/relayer/src/event.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

failed to resolve: use of undeclared type `IbcEvent`

error[E0433]: failed to resolve: use of undeclared type `IbcEvent`
   --> crates/relayer/src/event.rs:582:21
    |
582 |                     IbcEvent::OpenAckChannel(e) => {
    |                     ^^^^^^^^ use of undeclared type `IbcEvent`
    |
help: consider importing one of these items
    |
490 +     use crate::event::IbcEvent;
    |
490 +     use ibc_relayer_types::events::IbcEvent;
    |

Check failure on line 580 in crates/relayer/src/event.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

failed to resolve: use of undeclared type `ChannelAttributes`

error[E0433]: failed to resolve: use of undeclared type `ChannelAttributes`
   --> crates/relayer/src/event.rs:580:36
    |
580 |                         assert_eq!(ChannelAttributes::from(e), open_try.clone().into())
    |                                    ^^^^^^^^^^^^^^^^^ use of undeclared type `ChannelAttributes`
    |
help: consider importing this struct through its public re-export
    |
490 +     use crate::event::ChannelAttributes;
    |

Check failure on line 579 in crates/relayer/src/event.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

failed to resolve: use of undeclared type `IbcEvent`

error[E0433]: failed to resolve: use of undeclared type `IbcEvent`
   --> crates/relayer/src/event.rs:579:21
    |
579 |                     IbcEvent::OpenTryChannel(e) => {
    |                     ^^^^^^^^ use of undeclared type `IbcEvent`
    |
help: consider importing one of these items
    |
490 +     use crate::event::IbcEvent;
    |
490 +     use ibc_relayer_types::events::IbcEvent;
    |

Check failure on line 577 in crates/relayer/src/event.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

failed to resolve: use of undeclared type `ChannelAttributes`

error[E0433]: failed to resolve: use of undeclared type `ChannelAttributes`
   --> crates/relayer/src/event.rs:577:36
    |
577 |                         assert_eq!(ChannelAttributes::from(e), open_init.clone().into())
    |                                    ^^^^^^^^^^^^^^^^^ use of undeclared type `ChannelAttributes`
    |
help: consider importing this struct through its public re-export
    |
490 +     use crate::event::ChannelAttributes;
    |

Check failure on line 576 in crates/relayer/src/event.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

failed to resolve: use of undeclared type `IbcEvent`

error[E0433]: failed to resolve: use of undeclared type `IbcEvent`
   --> crates/relayer/src/event.rs:576:21
    |
576 |                     IbcEvent::OpenInitChannel(e) => {
    |                     ^^^^^^^^ use of undeclared type `IbcEvent`
    |
help: consider importing one of these items
    |
490 +     use crate::event::IbcEvent;
    |
490 +     use ibc_relayer_types::events::IbcEvent;
    |

Check failure on line 574 in crates/relayer/src/event.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

cannot find function `ibc_event_try_from_abci_event` in this scope

error[E0425]: cannot find function `ibc_event_try_from_abci_event` in this scope
   --> crates/relayer/src/event.rs:574:19
    |
574 |             match ibc_event_try_from_abci_event(&abci_event).ok() {
    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in this scope
    |
help: consider importing this function
    |
490 +     use crate::event::ibc_event_try_from_abci_event;
    |

Check failure on line 571 in crates/relayer/src/event.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

failed to resolve: use of undeclared type `AbciEvent`

error[E0433]: failed to resolve: use of undeclared type `AbciEvent`
   --> crates/relayer/src/event.rs:571:26
    |
571 |         abci_events.push(AbciEvent::from(close_confirm.clone()));
    |                          ^^^^^^^^^ use of undeclared type `AbciEvent`
    |
help: consider importing this struct through its public re-export
    |
490 +     use crate::event::AbciEvent;
    |

Check failure on line 570 in crates/relayer/src/event.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

failed to resolve: use of undeclared crate or module `channel_events`

error[E0433]: failed to resolve: use of undeclared crate or module `channel_events`
   --> crates/relayer/src/event.rs:570:29
    |
570 |         let close_confirm = channel_events::CloseConfirm::try_from(attributes).unwrap();
    |                             ^^^^^^^^^^^^^^ use of undeclared crate or module `channel_events`
    |
help: consider importing one of these items
    |
490 +     use crate::event::channel_events::CloseConfirm;
    |
490 +     use ibc_relayer_types::core::ics04_channel::events::CloseConfirm;
    |
help: if you import `CloseConfirm`, refer to it directly
    |
570 -         let close_confirm = channel_events::CloseConfirm::try_from(attributes).unwrap();
570 +         let close_confirm = CloseConfirm::try_from(attributes).unwrap();
    |

Check failure on line 569 in crates/relayer/src/event.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

failed to resolve: use of undeclared type `AbciEvent`

error[E0433]: failed to resolve: use of undeclared type `AbciEvent`
   --> crates/relayer/src/event.rs:569:26
    |
569 |         abci_events.push(AbciEvent::from(close_init.clone()));
    |                          ^^^^^^^^^ use of undeclared type `AbciEvent`
    |
help: consider importing this struct through its public re-export
    |
490 +     use crate::event::AbciEvent;
    |

Check failure on line 568 in crates/relayer/src/event.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

failed to resolve: use of undeclared crate or module `channel_events`

error[E0433]: failed to resolve: use of undeclared crate or module `channel_events`
   --> crates/relayer/src/event.rs:568:26
    |
568 |         let close_init = channel_events::CloseInit::try_from(attributes.clone()).unwrap();
    |                          ^^^^^^^^^^^^^^ use of undeclared crate or module `channel_events`
    |
help: consider importing one of these items
    |
490 +     use crate::event::channel_events::CloseInit;
    |
490 +     use ibc_relayer_types::core::ics04_channel::events::CloseInit;
    |
help: if you import `CloseInit`, refer to it directly
    |
568 -         let close_init = channel_events::CloseInit::try_from(attributes.clone()).unwrap();
568 +         let close_init = CloseInit::try_from(attributes.clone()).unwrap();
    |

Check failure on line 567 in crates/relayer/src/event.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

failed to resolve: use of undeclared type `AbciEvent`

error[E0433]: failed to resolve: use of undeclared type `AbciEvent`
   --> crates/relayer/src/event.rs:567:26
    |
567 |         abci_events.push(AbciEvent::from(open_confirm.clone()));
    |                          ^^^^^^^^^ use of undeclared type `AbciEvent`
    |
help: consider importing this struct through its public re-export
    |
490 +     use crate::event::AbciEvent;
    |

Check failure on line 566 in crates/relayer/src/event.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

failed to resolve: use of undeclared crate or module `channel_events`

error[E0433]: failed to resolve: use of undeclared crate or module `channel_events`
   --> crates/relayer/src/event.rs:566:28
    |
566 |         let open_confirm = channel_events::OpenConfirm::try_from(attributes.clone()).unwrap();
    |                            ^^^^^^^^^^^^^^ use of undeclared crate or module `channel_events`
    |
help: consider importing one of these items
    |
490 +     use crate::event::channel_events::OpenConfirm;
    |
490 +     use crate::event::connection_events::OpenConfirm;
    |
490 +     use ibc_relayer_types::core::ics03_connection::events::OpenConfirm;
    |
490 +     use ibc_relayer_types::core::ics04_channel::events::OpenConfirm;
    |
help: if you import `OpenConfirm`, refer to it directly
    |
566 -         let open_confirm = channel_events::OpenConfirm::try_from(attributes.clone()).unwrap();
566 +         let open_confirm = OpenConfirm::try_from(attributes.clone()).unwrap();
    |

Check failure on line 565 in crates/relayer/src/event.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

failed to resolve: use of undeclared type `AbciEvent`

error[E0433]: failed to resolve: use of undeclared type `AbciEvent`
   --> crates/relayer/src/event.rs:565:26
    |
565 |         abci_events.push(AbciEvent::from(open_ack.clone()));
    |                          ^^^^^^^^^ use of undeclared type `AbciEvent`
    |
help: consider importing this struct through its public re-export
    |
490 +     use crate::event::AbciEvent;
    |

Check failure on line 564 in crates/relayer/src/event.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

failed to resolve: use of undeclared crate or module `channel_events`

error[E0433]: failed to resolve: use of undeclared crate or module `channel_events`
   --> crates/relayer/src/event.rs:564:24
    |
564 |         let open_ack = channel_events::OpenAck::try_from(attributes.clone()).unwrap();
    |                        ^^^^^^^^^^^^^^ use of undeclared crate or module `channel_events`
    |
help: consider importing one of these items
    |
490 +     use crate::event::channel_events::OpenAck;
    |
490 +     use crate::event::connection_events::OpenAck;
    |
490 +     use ibc_relayer_types::core::ics03_connection::events::OpenAck;
    |
490 +     use ibc_relayer_types::core::ics04_channel::events::OpenAck;
    |
help: if you import `OpenAck`, refer to it directly
    |
564 -         let open_ack = channel_events::OpenAck::try_from(attributes.clone()).unwrap();
564 +         let open_ack = OpenAck::try_from(attributes.clone()).unwrap();
    |

Check failure on line 563 in crates/relayer/src/event.rs

See this annotation in the file changed.

@github-actions github-actions / clippy-no-default-features

failed to resolve: use of undeclared type `AbciEvent`

error[E0433]: failed to resolve: use of undeclared type `AbciEvent`
   --> crates/relayer/src/event.rs:563:26
    |
563 |         abci_events.push(AbciEvent::from(open_try.clone()));
    |                          ^^^^^^^^^ use of undeclared type `AbciEvent`
    |
help: consider importing this struct through its public re-export
    |
490 +     use crate::event::AbciEvent;
    |