Attempt to fix thick disc transfer functions #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tests for 3D grid interpolations. Also fixed a bug where the tuples were not being correctly unpacked when updating the grid indices.
It is now possible to select the root solving algorithm in the `root_solve` wrapper. Thick discs now by default use the Roots.jl solver, since it seems to converge significantly faster for those discs.
When trying to determine if a patch of a thick disc is visible, we run through the root solver again to determine whether the point on the datum plane and the point on the thick accretion disc are within some distance of eachother. It is not guarunteed that the root solver will be able to find the correct point for some emission radius when tracing over the thick disc. This is because that point might be obscured, which is effectively the whole point of re-tracing. So we wrap the root solving attempt with a try-catch, ignore any error that might occur, and just set the radius to NaN so that the point is later classed as not visible.
…verride in integration
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #202 and does a little bit towards #198, noting that the old Roots solver is a little better for Thick Discs because of the method for checking visibility.