Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit support with black and linting with flake8 #77

Closed
5 tasks done
astrochun opened this issue Apr 24, 2022 · 0 comments · Fixed by #81
Closed
5 tasks done

Add pre-commit support with black and linting with flake8 #77

astrochun opened this issue Apr 24, 2022 · 0 comments · Fixed by #81
Assignees
@astrochun
Labels
enhancement New feature or request
Milestone
v0.5.0

Comments

@astrochun
Copy link
Owner

astrochun commented Apr 24, 2022 •
edited
Loading

Similar to voxcharta-my-voting-record, we will add support for pre-commit.

  • Add .pre-commit-config.yaml and flake8
    • Configure pre-commit locally
  • Blackened code
    • Add badge for code style
  • Ensure it passes flake8
@astrochun astrochun added the enhancement New feature or request label Apr 24, 2022
@astrochun astrochun added this to the v0.5.0 milestone Apr 24, 2022
@astrochun astrochun self-assigned this Apr 24, 2022
astrochun added a commit that referenced this issue Apr 24, 2022
@astrochun
Add .flake8 and .pre-commit-config.yml #77
e680a67
@astrochun astrochun mentioned this issue May 5, 2022
Merged
astrochun added a commit that referenced this issue May 5, 2022
@astrochun
Add pre-commit support with black and linting with flake8 #77
655a597 
 - Add .flake8 and .pre-commit-config.yaml
 - Add GitHub actions for linting
 - Blackened tests
 - Add code style badge in README.md
 - Bump version: v0.4.9 -> 0.4.10
astrochun added a commit that referenced this issue May 5, 2022
@astrochun
Add pre-commit support with black and linting with flake8 #77
161fb63 
 - Add .flake8 and .pre-commit-config.yaml
 - Add GitHub actions for linting
 - Blackened tests
 - Add code style badge in README.md
 - Bump version: v0.4.9 -> 0.4.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@astrochun astrochun

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

Add pre-commit support with black and linting with flake8 astrochun/github-stats-pages
1 participant
@astrochun