Skip to content

Commit

Permalink
[astro] Fix graph view states (apache#17821)
Browse files Browse the repository at this point in the history
When apache#17821 was cherry-picked into
OSS 2.1.4, the `for` (v2-1-stable) vs `forEach` (main) wasn't accounted
for, and this changed the behavior of the method.

apache#18607 attempted to fix it, but
ultimately didn't change anything because main wasn't actually broken.

The solution is to `continue` so we finish the loop, not short-circuit
out with `return`.
  • Loading branch information
jedcunningham committed Jul 15, 2022
1 parent 6fc35c5 commit b23be74
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion airflow/www/static/js/graph.js
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ function updateNodesStates(tis) {
for (const nodeId of g.nodes()) {
const { elem } = g.node(nodeId);
if (!elem) {
return;
continue;
}
elem.setAttribute('class', `node enter ${getNodeState(nodeId, tis)}`);
elem.setAttribute('data-toggle', 'tooltip');
Expand Down

0 comments on commit b23be74

Please sign in to comment.