remove system admin role (#795)

* remove system admin role

* Updating role

cloud/auth/auth.go

@@ -305,22 +305,6 @@ func checkToken(c *config.Context, client astro.Client, out io.Writer) error {
 		return err
 	}
 	organizationID := self.AuthenticatedOrganizationID
-	roleBindings := self.User.RoleBindings
-
-	err = c.SetSystemAdmin(false)
-	if err != nil {
-		return err
-	}
-
-	for i := range roleBindings {
-		if roleBindings[i].Role == "SYSTEM_ADMIN" {
-			err = c.SetSystemAdmin(true)
-			if err != nil {
-				return err
-			}
-			break
-		}
-	}
 
 	if organizationID != "" {
 		err = c.SetContextKey("organization", organizationID)
@@ -434,10 +418,6 @@ func Logout(domain string, out io.Writer) {
 	if err != nil {
 		return
 	}
-	err = c.SetContextKey("isSystemAdmin", "")
-	if err != nil {
-		return
-	}
 	err = c.SetContextKey("user_email", "")
 	if err != nil {
 		return

cloud/auth/auth_test.go

@@ -29,7 +29,7 @@ var (
 		User: astro.User{
 			RoleBindings: []astro.RoleBinding{
 				{
-					Role: "SYSTEM_ADMIN",
+					Role: "WORKSPACE_ADMIN",
 				},
 			},
 		},
@@ -580,36 +580,32 @@ func TestLogout(t *testing.T) {
 	})
 
 	t.Run("success_with_email", func(t *testing.T) {
-		assertions := func(expIsSystemAdmin bool, expUserEmail string, expToken string) {
+		assertions := func(expUserEmail string, expToken string) {
 			contexts, err := config.GetContexts()
 			assert.NoError(t, err)
 			context := contexts.Contexts["localhost"]
 
-			isSystemAdmin, err := context.GetSystemAdmin()
 			assert.NoError(t, err)
-			assert.Equal(t, expIsSystemAdmin, isSystemAdmin)
 			assert.Equal(t, expUserEmail, context.UserEmail)
 			assert.Equal(t, expToken, context.Token)
 		}
 		testUtil.InitTestConfig(testUtil.LocalPlatform)
 		c, err := config.GetCurrentContext()
 		assert.NoError(t, err)
-		err = c.SetSystemAdmin(true)
-		assert.NoError(t, err)
 		err = c.SetContextKey("user_email", "test.user@astronomer.io")
 		assert.NoError(t, err)
 		err = c.SetContextKey("token", "Bearer some-token")
 		assert.NoError(t, err)
 		// test before
-		assertions(true, "test.user@astronomer.io", "Bearer some-token")
+		assertions("test.user@astronomer.io", "Bearer some-token")
 
 		// log out
 		c, err = config.GetCurrentContext()
 		assert.NoError(t, err)
 		Logout(c.Domain, os.Stdout)
 
 		// test after logout
-		assertions(false, "", "")
+		assertions("", "")
 	})
 }
 

cloud/deploy/deploy_test.go

@@ -643,7 +643,6 @@ func TestBuildImageFailure(t *testing.T) {
 	testUtil.InitTestConfig(testUtil.CloudPlatform)
 	ctx, err := config.GetCurrentContext()
 	assert.NoError(t, err)
-	ctx.SetSystemAdmin(true)
 
 	mockImageHandler := new(mocks.ImageHandler)
 

cmd/cloud/setup.go

@@ -262,11 +262,6 @@ func checkAPIKeys(astroClient astro.Client) (bool, error) {
 		return false, err
 	}
 
-	err = c.SetSystemAdmin(false)
-	if err != nil {
-		fmt.Println("admin settings incorrectly set you may experince permissions issues")
-	}
-
 	organizations, err := astroClient.GetOrganizations()
 	if err != nil {
 		return false, errors.Wrap(err, astro.AstronomerConnectionErrMsg)

config/context.go

@@ -200,32 +200,6 @@ func (c *Context) DeleteContext() error {
 	return nil
 }
 
-func (c *Context) SetSystemAdmin(value bool) error {
-	cKey, err := c.GetContextKey()
-	if err != nil {
-		return err
-	}
-
-	cfgPath := fmt.Sprintf("contexts.%s.%s", cKey, "isSystemAdmin")
-	viperHome.Set(cfgPath, value)
-	err = saveConfig(viperHome, HomeConfigFile)
-	if err != nil {
-		return err
-	}
-
-	return nil
-}
-
-func (c *Context) GetSystemAdmin() (bool, error) {
-	cKey, err := c.GetContextKey()
-	if err != nil {
-		return false, err
-	}
-
-	cfgPath := fmt.Sprintf("contexts.%s.%s", cKey, "isSystemAdmin")
-	return viperHome.GetBool(cfgPath), nil
-}
-
 func (c *Context) SetExpiresIn(value int64) error {
 	cKey, err := c.GetContextKey()
 	if err != nil {

config/context_test.go

@@ -183,32 +183,6 @@ func TestSetContextKey(t *testing.T) {
 	assert.Equal(t, "test", outCtx.Token)
 }
 
-func TestSystemAdmin(t *testing.T) {
-	initTestConfig()
-	ctx := Context{Domain: "localhost"}
-	err := ctx.SetSystemAdmin(true)
-	assert.NoError(t, err)
-
-	outCtx, err := ctx.GetContext()
-	assert.NoError(t, err)
-
-	val, err := outCtx.GetSystemAdmin()
-	assert.NoError(t, err)
-	assert.Equal(t, "localhost", outCtx.Domain)
-	assert.Equal(t, true, val)
-}
-
-func TestSystemAdminFailure(t *testing.T) {
-	initTestConfig()
-	ctx := Context{}
-	err := ctx.SetSystemAdmin(true)
-	assert.ErrorIs(t, err, ErrCtxConfigErr)
-
-	val, err := ctx.GetSystemAdmin()
-	assert.ErrorIs(t, err, ErrCtxConfigErr)
-	assert.Equal(t, false, val)
-}
-
 func TestExpiresIn(t *testing.T) {
 	initTestConfig()
 	ctx := Context{Domain: "localhost"}