update deployment from file blocks changing cluster

[jemishp]

Description

This PR detects when an update request using --deployment-file would change the existing deployment's cluster and does not allow that update. Instead it returns an errNotPermitted.

🎟 Issue(s)

Related #1012

🧪 Functional Testing

inspect an existing deployment's cluster

$ astro deployment inspect -n jp-test -k metadata.cluster_id
clbzeum5y000v0tyn8hbv5vsa
$ astro deployment inspect -n jp-test -k configuration.cluster_name
gtadi

request an update to change the cluster fails with an error

jpatel@jemishs-mbp astro-cli % cat deployment.yaml
deployment:
    environment_variables:
        - key: foo
          value: bar
        - key: bar
          value: awesome
          is_secret: true
    configuration:
        name: jp-test
        description: ""
        runtime_version: 7.1.0
        dag_deploy_enabled: false
        executor: KubernetesExecutor
        scheduler_au: 5
        scheduler_count: 1
        cluster_name: team-airflow-operator 
        workspace_name: CLI Test Workspace
    alert_emails:
        - test1@tester.com
        - test2@tester.com
$ astro deployment update --deployment-file deployment.yaml
Error: changing an existing deployment's cluster is not permitted

📸 Screenshots

📋 Checklist

• Rebased from the main (or release if patching) branch (before testing)
• Ran make test before taking out of draft
• Ran make lint before taking out of draft
• Added/updated applicable tests
• Tested against Astro-API (if necessary).
• Tested against Houston-API and Astronomer (if necessary).
• Communicated to/tagged owners of respective clients potentially impacted by these changes.
• Updated any related documentation

[codecov]

Codecov Report

Base: 87.72% // Head: 87.74% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (33de9fd) compared to base (8f54066).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1013      +/-   ##
==========================================
+ Coverage   87.72%   87.74%   +0.02%     
==========================================
  Files         112      112              
  Lines        9923     9926       +3     
==========================================
+ Hits         8705     8710       +5     
+ Misses        711      710       -1     
+ Partials      507      506       -1     

Impacted Files	Coverage Δ
cloud/deployment/fromfile/fromfile.go	100.00% <100.00%> (ø)
cmd/cloud/deployment.go	93.30% <100.00%> (+0.83%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[sunkickr]

Thanks! LGTM