Sql cli/compat matrix #1026
Merged
Sql cli/compat matrix #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimberman
requested review from
andriisoldatenko,
aliotta,
neel-astro,
AmFlint,
kushalmalani,
sunkickr and
jemishp
as code owners
dimberman
force-pushed
the
sql-cli/compat-matrix
branch
from
f3458d3 to
a501ac5
Compare
pankajkoti
reviewed
Jan 19, 2023
…compatibility check before adding the SQL CLI to the docker image. This ensures that we do not download a new version of the SQL CLI that breaks the Astro CLI
dimberman
force-pushed
the
sql-cli/compat-matrix
branch
from
9666d53 to
25db39c
Compare
Codecov ReportBase: 87.69% // Head: 87.72% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1026 +/- ##
==========================================
+ Coverage 87.69% 87.72% +0.02%
==========================================
Files 113 113
Lines 10159 10156 -3
==========================================
Hits 8909 8909
+ Misses 733 732 -1
+ Partials 517 515 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
pankajkoti
approved these changes
Jan 19, 2023
for more information, see https://pre-commit.ci
tatiana
approved these changes
Jan 19, 2023
kushalmalani
approved these changes
Jan 20, 2023
kushalmalani
pushed a commit
that referenced
this pull request
Jan 20, 2023
* This pull requests allows the Astro CLI to consult the SQL CLI for a compatibility check before adding the SQL CLI to the docker image. This ensures that we do not download a new version of the SQL CLI that breaks the Astro CLI * increase coverage * increase coverage * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull requests allows the Astro CLI to consult the SQL CLI for a compatibility check before adding the SQL CLI to the docker image. This ensures that we do not download a new version of the SQL CLI that breaks the Astro CLI
🎟 Issue(s)
Related #XXX
🧪 Functional Testing
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft