Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use installed flow version to get compatibiltiies from matrix #1035

Merged
merged 10 commits into from
Jan 24, 2023
Merged

Use installed flow version to get compatibiltiies from matrix #1035

merged 10 commits into from
Jan 24, 2023

Conversation

pankajkoti
Copy link
Contributor

@pankajkoti pankajkoti commented Jan 23, 2023 •
edited
Loading

Description

Currently, we get the constraint of the SQL CLI python package that is used for installing flow and use the same constraint as a key to match in the compatibility matrix. However the compatibility matrix is meant to contain specific Pypi versions as key and not the constraints itself. We therefore need to get the installed flow version and use that flow version to find the compatibilities. For this reason, we call the flow version command which gives us the installed version of flow and we use the same to match it in the matrix.

🎟 Issue(s)

closes: astronomer/astro-sdk#1642

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@pankajkoti pankajkoti changed the title 1642 use installed flow version Use installed flow version to get compatibiltiies from matrix Jan 23, 2023
feluelle
feluelle reviewed Jan 24, 2023
View reviewed changes
cmd/sql/flow.go Outdated Show resolved Hide resolved
feluelle
feluelle approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@feluelle feluelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pankajkoti
pankajkoti commented Jan 24, 2023
View reviewed changes
cmd/sql/flow.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 24, 2023 •
edited
Loading

Codecov Report

Base: 87.73% // Head: 87.67% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (14dc60e) compared to base (6beab0a).
Patch coverage: 47.05% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1035      +/-   ##
==========================================
- Coverage   87.73%   87.67%   -0.06%     
==========================================
  Files         113      113              
  Lines       10229    10239      +10     
==========================================
+ Hits         8974     8977       +3     
- Misses        735      743       +8     
+ Partials      520      519       -1
Impacted Files Coverage Δ
cmd/sql/flow.go 78.69% <40.00%> (-0.98%) ⬇️
sql/flow.go 91.15% <100.00%> (-0.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pankajkoti pankajkoti marked this pull request as ready for review January 24, 2023 12:22
@kushalmalani kushalmalani merged commit 4075a22 into main Jan 24, 2023
@kushalmalani kushalmalani deleted the 1642-use-installed-flow-version branch January 24, 2023 20:54
kushalmalani pushed a commit that referenced this pull request Jan 24, 2023
@pankajkoti @pre-commit-ci @kushalmalani
Use installed flow version to get compatibiltiies from matrix (#1035)
ddfb373 
* Get installed flow version to map against compatibility matrix

* Use base branch to fetch compatibility matrix

* Update cmd/sql/flow.go

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix tests

* Add tests for errors

* Fix lint error

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix failing test

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feluelle feluelle feluelle approved these changes

@kushalmalani kushalmalani kushalmalani approved these changes

@tatiana tatiana Awaiting requested review from tatiana

@dimberman dimberman Awaiting requested review from dimberman

@andriisoldatenko andriisoldatenko Awaiting requested review from andriisoldatenko

@aliotta aliotta Awaiting requested review from aliotta

@neel-astro neel-astro Awaiting requested review from neel-astro neel-astro is a code owner

@AmFlint AmFlint Awaiting requested review from AmFlint

@sunkickr sunkickr Awaiting requested review from sunkickr

@jemishp jemishp Awaiting requested review from jemishp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get astro flow version and pass it to deploy flow to match the key in compatibility matrix
3 participants
@pankajkoti @feluelle @kushalmalani