change direct docker calls to use :rw instead of :z for volume flags #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the volume flags use by astro dev parse and other astro dev commands that directly call docker to not attempt to mount the volume for sharing across multiple containers and to explicitly mount these as read-write instead of read-write shared. Since these are one-shot containers, this setting will not impact users and will remove attempts to by certain container binaries to set extended attributes which are not valid on OS X. This change improves compatability with podman on OS X.
rob-1126
requested review from
andriisoldatenko,
aliotta,
neel-astro,
AmFlint,
kushalmalani,
sunkickr and
jemishp
as code owners
sunkickr
approved these changes
Feb 1, 2023
|
I checked it on my end under docker on osx.
…--Rob
On Wed, Feb 1, 2023, 9:42 AM David Koenitzer ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM. Should I try it out on Docker?
—
Reply to this email directly, view it on GitHub
<#1054 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVHHXBWDIIXCE3HIHQZFIUTWVJY6BANCNFSM6AAAAAAUM2GA7Q>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change improves compatability with podman on OS X.
Changes the volume flags use by astro dev parse and other astro dev commands that directly call docker to not attempt to mount the volume for sharing across multiple containers and to explicitly mount these as read-write instead of read-write shared.
Since these are one-shot containers, this setting will not impact users and will remove attempts to by certain container binaries to set extended attributes which are not valid on OS X.
🧪 Functional Testing
Built from source and ran ~/astro-cli/astro dev parse under podman on OS X.
📸 Screenshots
📋 Checklist
make testbefore taking out of draft (FAILS pre-existing code-coverage tests)make lintbefore taking out of draft