Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check minor version and default keys to match in compatibility matrix #1063

Merged
merged 10 commits into from
Feb 3, 2023

Conversation

pankajkoti
Copy link
Contributor

The plan is that Astro CLI integration should allow version match as per the below steps:

  1. Try to find an exact match of Astro CLI version in the compatibility matrix e.g. 1.10.0
  2. If no exact match is found, trim the version to remove the patch version and match until the minor version e.g. 1.10
  3. If still does not match, match a key named 'default' which is set to install the latest SQL CLI version.

🎟 Issue(s)

Related astronomer/astro-sdk#1673

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

The plan is that Astro CLI integration should allow version match as
per the below steps:
1. Try to find an exact match of Astro CLI version in the compatibility
   matrix e.g. 1.10.0
2. If no exact match is found, trim the version to remove the patch
   version and match until the minor version e.g. 1.10
3. If still does not match, match a key named 'default' which is set
   to install the latest SQL CLI version.
sql/flow.go Outdated Show resolved Hide resolved
sql/flow_config_test.go Outdated Show resolved Hide resolved
sql/flow_config_test.go Outdated Show resolved Hide resolved
sql/flow_config_test.go Outdated Show resolved Hide resolved
sql/flow.go Outdated Show resolved Hide resolved
Copy link
Contributor

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, @pankajkoti !

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 87.84% // Head: 87.83% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (1d1101d) compared to base (2096a47).
Patch coverage: 93.10% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1063      +/-   ##
==========================================
- Coverage   87.84%   87.83%   -0.02%     
==========================================
  Files         113      113              
  Lines       10638    10644       +6     
==========================================
+ Hits         9345     9349       +4     
- Misses        759      760       +1     
- Partials      534      535       +1     
Impacted Files Coverage Δ
airflow/docker.go 85.10% <ø> (ø)
config/config.go 80.00% <ø> (ø)
config/types.go 77.77% <ø> (ø)
sql/flow_config.go 83.33% <66.66%> (-2.72%) ⬇️
airflow/container.go 67.69% <100.00%> (+0.50%) ⬆️
airflow/docker_image.go 85.54% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

sql/flow_config.go Outdated Show resolved Hide resolved
@kushalmalani kushalmalani merged commit f595c19 into main Feb 3, 2023
@kushalmalani kushalmalani deleted the 1673-minor-version-match branch February 3, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants