-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check minor version and default keys to match in compatibility matrix #1063
Conversation
The plan is that Astro CLI integration should allow version match as per the below steps: 1. Try to find an exact match of Astro CLI version in the compatibility matrix e.g. 1.10.0 2. If no exact match is found, trim the version to remove the patch version and match until the minor version e.g. 1.10 3. If still does not match, match a key named 'default' which is set to install the latest SQL CLI version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks, @pankajkoti !
Codecov ReportBase: 87.84% // Head: 87.83% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1063 +/- ##
==========================================
- Coverage 87.84% 87.83% -0.02%
==========================================
Files 113 113
Lines 10638 10644 +6
==========================================
+ Hits 9345 9349 +4
- Misses 759 760 +1
- Partials 534 535 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Co-authored-by: Neel Dalsania <neel.dalsania@astronomer.io>
The plan is that Astro CLI integration should allow version match as per the below steps:
🎟 Issue(s)
Related astronomer/astro-sdk#1673
🧪 Functional Testing
📸 Screenshots
📋 Checklist
make test
before taking out of draftmake lint
before taking out of draft