Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment name not found returns error #1074

Merged
merged 5 commits into from
Feb 15, 2023
Merged

deployment name not found returns error #1074

merged 5 commits into from
Feb 15, 2023

Conversation

sunkickr
Copy link
Contributor

@sunkickr sunkickr commented Feb 9, 2023

Description

If the user supplies a deployment name that does not exist an error is returned similar to what happens if a user supplies a deployment ID that does not exits

🎟 Issue(s)

🧪 Functional Testing

manual testing

📸 Screenshots

Screenshot 2023-02-09 at 9 49 14 AM

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Base: 87.83% // Head: 87.83% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (1725b66) compared to base (b041b32).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1074   +/-   ##
=======================================
  Coverage   87.83%   87.83%           
=======================================
  Files         113      113           
  Lines       10641    10642    +1     
=======================================
+ Hits         9346     9347    +1     
  Misses        760      760           
  Partials      535      535           
Impacted Files Coverage Δ
cloud/deployment/deployment.go 90.90% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sunkickr sunkickr merged commit bfd7648 into main Feb 15, 2023
@sunkickr sunkickr deleted the name-issues branch February 15, 2023 15:34
@sunkickr sunkickr self-assigned this Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants