Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move workspace list to using core api #1259

Merged
merged 8 commits into from
Jun 15, 2023
Merged

Conversation

kushalmalani
Copy link
Contributor

@kushalmalani kushalmalani commented Jun 14, 2023

Description

Describe the purpose of this pull request.

Move workspace list to using core api

🎟 Issue(s)

Related #1260

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@kushalmalani kushalmalani self-assigned this Jun 14, 2023
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage: 95.45% and project coverage change: -0.02 ⚠️

Comparison is base (b857ffa) 87.64% compared to head (a259b5c) 87.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1259      +/-   ##
==========================================
- Coverage   87.64%   87.63%   -0.02%     
==========================================
  Files         110      110              
  Lines       12569    12558      -11     
==========================================
- Hits        11016    11005      -11     
- Misses        903      904       +1     
+ Partials      650      649       -1     
Impacted Files Coverage Δ
astro-client/astro.go 100.00% <ø> (ø)
cloud/auth/auth.go 84.55% <90.90%> (-0.74%) ⬇️
cloud/workspace/workspace.go 83.04% <95.00%> (+1.26%) ⬆️
cloud/deployment/deployment.go 91.19% <100.00%> (ø)
cloud/deployment/fromfile/fromfile.go 98.80% <100.00%> (ø)
cmd/cloud/workspace.go 96.55% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kushalmalani kushalmalani marked this pull request as ready for review June 15, 2023 06:47
Copy link
Contributor

@sunkickr sunkickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great

@kushalmalani kushalmalani merged commit cec4b1d into main Jun 15, 2023
@kushalmalani kushalmalani deleted the move-workspace-commands-core branch June 15, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants