Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix when team has no members and list team users is called #1271

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

aliotta
Copy link
Contributor

@aliotta aliotta commented Jun 19, 2023

Description

Bug fix when team has no members and list team users is called

🎟 Issue(s)

Related #1269

🧪 Functional Testing

created an team without membership and called the cli method

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (813e8b2) 87.51% compared to head (32ed76b) 87.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1271   +/-   ##
=======================================
  Coverage   87.51%   87.51%           
=======================================
  Files         110      110           
  Lines       12996    12999    +3     
=======================================
+ Hits        11373    11376    +3     
  Misses        949      949           
  Partials      674      674           
Impacted Files Coverage Δ
cloud/team/team.go 84.48% <100.00%> (+0.09%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aliotta aliotta merged commit 9effcb1 into main Jun 19, 2023
@aliotta aliotta deleted the bugFixListTeamUserEMptyMembership branch June 19, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants