Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn user of updating idp managed teams #1273

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Conversation

missing1984
Copy link
Contributor

@missing1984 missing1984 commented Jun 20, 2023

Description

warn user of updating idp managed teams

🎟 Issue(s)

https://github.com/astronomer/astro/issues/14251

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (9effcb1) 87.51% compared to head (4e2a1ff) 87.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1273      +/-   ##
==========================================
+ Coverage   87.51%   87.53%   +0.01%     
==========================================
  Files         110      110              
  Lines       12999    13019      +20     
==========================================
+ Hits        11376    11396      +20     
  Misses        949      949              
  Partials      674      674              
Impacted Files Coverage Δ
cloud/team/team.go 85.11% <100.00%> (+0.62%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@missing1984 missing1984 marked this pull request as ready for review June 20, 2023 23:10
Copy link
Contributor

@neel-astro neel-astro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit from consistency point of view, otherwise LGTM

cloud/team/team.go Outdated Show resolved Hide resolved
@kushalmalani kushalmalani merged commit c21e563 into main Jun 21, 2023
@kushalmalani kushalmalani deleted the mluo/teams-improvement branch June 21, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants