Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error message #1285

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Update error message #1285

merged 2 commits into from
Jun 27, 2023

Conversation

kushalmalani
Copy link
Contributor

@kushalmalani kushalmalani commented Jun 27, 2023

Description

Describe the purpose of this pull request.

Update error message

🎟 Issue(s)

Related #1267

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@kushalmalani kushalmalani self-assigned this Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f023de1) 87.52% compared to head (254bbc5) 87.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1285   +/-   ##
=======================================
  Coverage   87.52%   87.53%           
=======================================
  Files         110      110           
  Lines       13087    13088    +1     
=======================================
+ Hits        11455    11456    +1     
  Misses        955      955           
  Partials      677      677           
Impacted Files Coverage Δ
cloud/deployment/workerqueue/workerqueue.go 98.28% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kushalmalani kushalmalani merged commit 20e2a5e into main Jun 27, 2023
@kushalmalani kushalmalani deleted the update-error-message branch June 27, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants