Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding wait flag for astro deploy to be healthy #1293

Merged
merged 9 commits into from
Jul 10, 2023
Merged

Conversation

kushalmalani
Copy link
Contributor

@kushalmalani kushalmalani commented Jul 5, 2023

Description

Describe the purpose of this pull request.

Adding wait flag for astro deploy to be healthy

🎟 Issue(s)

Related #1086

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.03 ⚠️

Comparison is base (601f9c6) 87.14% compared to head (24653c2) 87.11%.

❗ Current head 24653c2 differs from pull request most recent head ca13e39. Consider uploading reports for the commit ca13e39 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1293      +/-   ##
==========================================
- Coverage   87.14%   87.11%   -0.03%     
==========================================
  Files         114      114              
  Lines       13305    13315      +10     
==========================================
+ Hits        11594    11599       +5     
- Misses       1021     1026       +5     
  Partials      690      690              
Impacted Files Coverage Δ
cloud/deploy/deploy.go 70.73% <64.28%> (-0.32%) ⬇️
cloud/deployment/deployment.go 91.39% <100.00%> (ø)
cmd/cloud/deploy.go 89.39% <100.00%> (+0.33%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kushalmalani kushalmalani marked this pull request as ready for review July 5, 2023 15:44
@kushalmalani kushalmalani self-assigned this Jul 10, 2023
@kushalmalani kushalmalani merged commit f4e6650 into main Jul 10, 2023
@kushalmalani kushalmalani deleted the deploy-wait-healthy branch July 10, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants