Add team org role crud #1296
Add team org role crud #1296
Conversation
…d view org role via list command
aliotta
requested review from
neel-astro,
kushalmalani and
sunkickr
as code owners
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1296 +/- ##
==========================================
+ Coverage 87.31% 87.34% +0.03%
==========================================
Files 113 113
Lines 13255 13327 +72
==========================================
+ Hits 11573 11641 +68
- Misses 992 994 +2
- Partials 690 692 +2
☔ View full report in Codecov by Sentry. |
cmd/cloud/organization.go
Outdated
| @@ -327,6 +330,41 @@ func teamUpdate(cmd *cobra.Command, out io.Writer, args []string) error { | |||
| return team.UpdateTeam(id, teamName, teamDescription, out, astroCoreClient) | |||
| } | |||
|
|
|||
| func newOrganizationTeamUpdateRoleCmd(out io.Writer) *cobra.Command { | |||
| cmd := &cobra.Command{ | |||
| Use: "update-org-role [team-id]", | |||
There was a problem hiding this comment.
I'm open to other cmd names lmk what you think
There was a problem hiding this comment.
I think it should be part of the team update command because the org role is sort of property for the org team resource, and also it is a flag for the team create command, so it should also be the same flag for the team update command, wdyt?
There was a problem hiding this comment.
yeah makes sense done
Description
🎟 Issue(s)
Related #14652
🧪 Functional Testing
Tested against the pr preview of https://github.com/astronomer/astro/pull/14609
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft