Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display is idp managed flag in list users command #1299

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

missing1984
Copy link
Contributor

@missing1984 missing1984 commented Jul 7, 2023

Description

display is idp managed flag in list users command

🎟 Issue(s)

https://github.com/astronomer/astro/issues/14686

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e672f4c) 87.13% compared to head (820bd10) 87.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1299   +/-   ##
=======================================
  Coverage   87.13%   87.13%           
=======================================
  Files         114      114           
  Lines       13298    13300    +2     
=======================================
+ Hits        11587    11589    +2     
  Misses       1021     1021           
  Partials      690      690           
Impacted Files Coverage Δ
cloud/user/user.go 92.25% <100.00%> (+0.05%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kushalmalani kushalmalani merged commit 52606f8 into main Jul 7, 2023
@kushalmalani kushalmalani deleted the mluo/idp-users-flag branch July 7, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants