Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow workspace author role via cli #1308

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Allow workspace author role via cli #1308

merged 2 commits into from
Aug 24, 2023

Conversation

aliotta
Copy link
Contributor

@aliotta aliotta commented Jul 10, 2023

Description

Updates user, token, and team cli create and update methods to allow for new AUTHOR role.

🧪 Functional Testing

Ran the cli locally against prod and verified it worked as expected

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage: 94.11% and no project coverage change.

Comparison is base (f4e6650) 87.12% compared to head (b79257c) 87.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1308   +/-   ##
=======================================
  Coverage   87.12%   87.12%           
=======================================
  Files         114      114           
  Lines       13323    13323           
=======================================
  Hits        11607    11607           
  Misses       1026     1026           
  Partials      690      690           
Impacted Files Coverage Δ
cmd/cloud/workspace.go 94.72% <93.75%> (ø)
cloud/user/user.go 92.25% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chomipi88
Copy link

@kushalmalani kushalmalani changed the title allow workspace author role via cli [DO NO MERGE] allow workspace author role via cli Jul 10, 2023
@kushalmalani kushalmalani marked this pull request as draft July 10, 2023 20:56
@aliotta aliotta changed the title [DO NO MERGE] allow workspace author role via cli Allow workspace author role via cli Aug 24, 2023
@aliotta aliotta marked this pull request as ready for review August 24, 2023 15:13
@aliotta aliotta merged commit 4572a01 into main Aug 24, 2023
@aliotta aliotta deleted the allowAuthorRole branch August 24, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants