Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for updating deployments with larger scheduler #1309

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

kushalmalani
Copy link
Contributor

@kushalmalani kushalmalani commented Jul 11, 2023

Description

Describe the purpose of this pull request.

Fix for updating deployments with larger scheduler

🎟 Issue(s)

Related #1310

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

Error before Bug Fix
Screenshot 2023-07-11 at 11 23 05

Successful Update after fix
Screenshot 2023-07-11 at 11 23 21

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@kushalmalani kushalmalani self-assigned this Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8ee6486) 87.12% compared to head (d1dc611) 87.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1309   +/-   ##
=======================================
  Coverage   87.12%   87.12%           
=======================================
  Files         114      114           
  Lines       13323    13324    +1     
=======================================
+ Hits        11607    11608    +1     
  Misses       1026     1026           
  Partials      690      690           
Impacted Files Coverage Δ
cloud/deployment/deployment.go 91.40% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kushalmalani kushalmalani marked this pull request as ready for review July 11, 2023 18:25
@kushalmalani kushalmalani merged commit 69551e8 into main Jul 11, 2023
@kushalmalani kushalmalani deleted the fix-deployment-update-large-scheduler branch July 11, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants