Upgrade command #1314
Merged
Upgrade command #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…to upgrade-command
jwitz
reviewed
Jul 26, 2023
jwitz
reviewed
Jul 26, 2023
Co-authored-by: Jake Witz <74574233+jwitz@users.noreply.github.com>
jwitz
reviewed
Jul 26, 2023
Co-authored-by: Jake Witz <74574233+jwitz@users.noreply.github.com>
Co-authored-by: Jake Witz <74574233+jwitz@users.noreply.github.com>
…to upgrade-command
neel-astro
approved these changes
Aug 1, 2023
| } | ||
|
|
||
| // add upgrade-test* to the gitignore | ||
| err = fileutil.AddLineToFile("./.gitignore", "upgrade-test*", "") |
There was a problem hiding this comment.
nit: should we remove this line before this function end as part of defer, else we might end up adding this line to the file each time the command is executed
There was a problem hiding this comment.
This line is only added if it isn't already in the file
kushalmalani
approved these changes
Aug 1, 2023
Co-authored-by: Neel Dalsania <neel.dalsania@astronomer.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
astro dev upgrade-test
PRD: https://www.notion.so/astronomerio/Astro-CLI-Upgrade-Check-Command-7d74a6e67a2e447ca38bd00258e429d0
🎟 Issue(s)
Related: #1306
🧪 Functional Testing
manual testing
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft