Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a description flag for deploy #1323

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

kushalmalani
Copy link
Contributor

@kushalmalani kushalmalani commented Jul 27, 2023

Description

Describe the purpose of this pull request.

Adding a description flag for deploy

🎟 Issue(s)

Related astronomer/astro#14751

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

Screenshot 2023-07-27 at 00 14 50 Screenshot 2023-07-27 at 00 15 07

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@kushalmalani kushalmalani self-assigned this Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (eb70430) 87.18% compared to head (3a1b370) 87.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1323   +/-   ##
=======================================
  Coverage   87.18%   87.18%           
=======================================
  Files         114      114           
  Lines       13374    13377    +3     
=======================================
+ Hits        11660    11663    +3     
  Misses       1025     1025           
  Partials      689      689           
Files Changed Coverage Δ
astro-client/astro.go 100.00% <100.00%> (ø)
cloud/deploy/deploy.go 71.17% <100.00%> (+0.07%) ⬆️
cmd/cloud/deploy.go 89.70% <100.00%> (+0.31%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kushalmalani kushalmalani marked this pull request as ready for review July 27, 2023 07:15
Copy link
Contributor

@neel-astro neel-astro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally looks fine to me, left a comment on moving to the pointer

astro-client/astro.go Show resolved Hide resolved
@kushalmalani kushalmalani merged commit f2ce354 into main Jul 27, 2023
@kushalmalani kushalmalani deleted the add-deploy-description branch July 27, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants