Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup unused code #1325

Merged
merged 2 commits into from
Jul 28, 2023
Merged

cleanup unused code #1325

merged 2 commits into from
Jul 28, 2023

Conversation

kushalmalani
Copy link
Contributor

@kushalmalani kushalmalani commented Jul 28, 2023

Description

Describe the purpose of this pull request.

Cleanup unused code

🎟 Issue(s)

Related #XXX

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@kushalmalani kushalmalani self-assigned this Jul 28, 2023
@kushalmalani kushalmalani marked this pull request as ready for review July 28, 2023 06:30
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (f2ce354) 87.18% compared to head (13cc393) 87.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1325      +/-   ##
==========================================
- Coverage   87.18%   87.17%   -0.01%     
==========================================
  Files         114      114              
  Lines       13377    13367      -10     
==========================================
- Hits        11663    11653      -10     
  Misses       1025     1025              
  Partials      689      689              
Files Changed Coverage Δ
pkg/util/util.go 81.48% <ø> (-2.90%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kushalmalani kushalmalani enabled auto-merge (squash) July 28, 2023 06:48
Copy link
Contributor

@neel-astro neel-astro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup 🙇

@kushalmalani kushalmalani merged commit c2bcc04 into main Jul 28, 2023
@kushalmalani kushalmalani deleted the cleanup-unused-code branch July 28, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants